[Feature Request] Replace existing content about mc-acf-flexible-template HOT 5 CLOSED

Hi Marie, thanks to you for creating acf-flexible-template. I'm a bit newbie in github, and Forking and pull requests are my first steps. I would ask to you how I can create other pull requests. It's not so celar for me. Recently, I've submitted to you a PR that has been merged. But now there are other PR in queue: how I can create another PR without having conflicts with other contributors? If you can could yiu point me to the right direction? Thanks in advance :) Virgilio Il giorno gio 1 nov 2018 alle ore 15:45 Marie Comet < [email protected]> ha scritto:

Hi Marie, thank you very much for clarifications. Syncing a fork was the missing tile. I supposed there would be such a system like this, but there is no any action button in github website. Maybe is more easy to do this using git in local machine, but currently I'm using github website only. Anyway, all this means that contributors should be careful when creating pull request. Expecially when two ore more are working on the same files at the same time. I suppose that someone have to wait to sync its fork with previous pull requests before creating another pull request. thank you very much, really clear! :) Returning to your plugin *mc-acf-flexible-templates*, I would like submit another pull request related to the *mc_ft_acf_update_template* function. This function is hooked with the *acf/save_post* filter and the purpose is to update the post_meta fields (*_flex_layout_parent* and *_flex_layout_data*) without saving any *$_POST['acf']* data into the database. Currently the function loop through all fields and everytime find a non empty value in *$_POST['acf']*, it updates the _flex_layout_data. Thi means that we cannot use or create other acf fields into the post screen. This prevent users to extended the acf_template post type screen with other acf fields. I've rewritten a bit of this function so we can get the specific flexible template data using the _flex_layout_parent field key instead of looping through the available fields. Currently I'm using this method in a local version of the plugin. And this give me the ability to extend the acf_template screen addiing extra acf fields (for example a screenshot of the template). If you find useful this idea I can create another Pull Request, so maybe you can dive more clearly into what I'm try to say. Please, let me know what you think, thank you very much! Virgilio Il giorno ven 2 nov 2018 alle ore 21:23 Marie Comet < [email protected]> ha scritto: