Can't save or load from clone about mc-acf-flexible-template HOT 11 OPEN

Hi @rafegoldberg
I think it's the same issue that #8 which I can't resolve for now.

from mc-acf-flexible-template.

Hi @julesrenaud, do you think you can make a pull request for this fix ?

from mc-acf-flexible-template.

@MarieComet certainly, will do. Would you mind if I were to also do a second one which makes it optional to register the acf_template_tax taxonomy? It can be confusing for the user to see "Uncategorized" in the UI.

from mc-acf-flexible-template.

@PseudoPsychosis I believe so. I think the solution I'm working on will fix both issues. I will post a PR soon.

from mc-acf-flexible-template.

I gotchya. In any case, let me say again that this is an awesome plugin! It addresses a sorely missed functionality in ACF's core. Very cool.

from mc-acf-flexible-template.

Adding the following code block after line 351 in mc-acf-flexible-template.php fixes the issue for flexible fields that are inside a clone field. It doesn't fix #8, but it could also be fixed easily in similar fashion.

if ( ! $fields && ! empty( $_POST['acf'] ) && is_array( $_POST['acf'] ) ) {
    foreach ( $_POST['acf'] as $field ) {
        if ( ! is_array( $field ) )
            continue;

        foreach ( $field as $key => $value ) {
            $length = strlen( $parent_key );

            if ( substr( $key, -$length ) === $parent_key ) {
                $fields = $value;
            }
        }
    }
}

from mc-acf-flexible-template.

Adding the following code block after line 351 in mc-acf-flexible-template.php fixes the issue for flexible fields that are inside a clone field. It doesn't fix #8, but it could also be fixed easily in similar fashion.

if ( ! $fields && ! empty( $_POST['acf'] ) && is_array( $_POST['acf'] ) ) {
    foreach ( $_POST['acf'] as $field ) {
        if ( ! is_array( $field ) )
            continue;

        foreach ( $field as $key => $value ) {
            $length = strlen( $parent_key );

            if ( substr( $key, -$length ) === $parent_key ) {
                $fields = $value;
            }
        }
    }
}

You mention possibly being able to use this as a fix for #8, which has been something that I have been struggling with for some time. Can you create a PR to fix #8 too?

Thanks @julesrenaud!

from mc-acf-flexible-template.

@PseudoPsychosis I believe so. I think the solution I'm working on will fix both issues. I will post a PR soon.

You rock. Thank you!

from mc-acf-flexible-template.

Any update on a fix? desperately want to be able to use this plugin

from mc-acf-flexible-template.

It's been a few years but it seems that there was a PR for this that was never merged here #14

from mc-acf-flexible-template.

@CalebBarnes PR #14 is not related to this issue ("Make acf template tax optional") : 1d09c88

from mc-acf-flexible-template.