marcusmolchany / tokengate Goto Github PK

looking for feedback on v1. all feedback is appreciated.

if you have specific opinions on the following things let me know:

• api exposed in index.ts

other things that are on my mind:

• docs or utilities for a secure challenge flow. challenge message should include: nonce, timestamp, human-readable message, domain and chain information.
• add /examples dir and replit with working examples
• better api for erc20/721/777 vs erc1155
• look into Sign-in with Ethereum and EIP-4361
• support signTypedData()
• support batchBalanceOf for erc1155
• allowing for a web3.js provider to be appropriately wrapped by ethers (https://docs.ethers.io/v5/api/providers/other/#Web3Provider)
• confirming that wallets other than metamask and wallet connect work appropriately
• separating the signature verification step, and the token gating steps
• making the token gating step compose multiple token gates. the default token gate utility would be to check for a .balanceOf() for a giving token address

use .gte() BigNumber comparison rather than >= https://github.com/marcusmolchany/tokengate/blob/main/src/tokenGate.ts#L75

options:

• bignumber.js (https://mikemcl.github.io/bignumber.js/#gte)
• BN.js (ethers) (https://docs.ethers.io/v5/api/utils/bignumber/#BigNumber--BigNumber--methods--comparison-and-equivalence)