Git Product home page Git Product logo

Comments (5)

marchof avatar marchof commented on June 11, 2024

@AlanBateman This is a very simple tool which simply compares class files one by one. I wrote it primarly for myself to identify areas where we get changes and have direct links to JavaDoc.

For now it does not consider type hierarchies and can therefore not check whether a change is source compatible. If you're looking for a detailed analysis you should use more sophisticated tools like japicmp. JDK reports can be found here:(https://github.com/AdoptOpenJDK/jdk-api-diff)

Anyways, thanks for the examples! I leave this ticket open and see whether I can add some improvements if I find some spare time.

from java-almanac.

marchof avatar marchof commented on June 11, 2024

Background info about compatibility:

from java-almanac.

marchof avatar marchof commented on June 11, 2024

The inner classes of WeakPairMap are actually public in Java 11:

$ ./java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)

$ ./javap java.lang.WeakPairMap.Pair.Lookup
Compiled from "WeakPairMap.java"
public final class java.lang.WeakPairMap$Pair$Lookup<K1, K2> implements java.lang.WeakPairMap$Pair<K1, K2> {
  java.lang.WeakPairMap$Pair$Lookup(K1, K2);
  public K1 first();
  public K2 second();
  public int hashCode();
  public boolean equals(java.lang.Object);
}

$ ./javap java.lang.WeakPairMap.Pair.Weak
Compiled from "WeakPairMap.java"
public final class java.lang.WeakPairMap$Pair$Weak<K1, K2> extends java.lang.WeakPairMap$WeakRefPeer<K1> implements java.lang.WeakPairMap$Pair<K1, K2> {
  java.lang.WeakPairMap$Pair$Weak(K1, K2, java.lang.ref.ReferenceQueue<java.lang.Object>);
  java.lang.WeakPairMap$Pair$Weak<?, ?> weakPair();
  public K1 first();
  public K2 second();
  public int hashCode();
  public boolean equals(java.lang.Object);
}

from java-almanac.

AlanBateman avatar AlanBateman commented on June 11, 2024

Does the tool look at the access flags in the InnerClasses attribute?

from java-almanac.

marchof avatar marchof commented on June 11, 2024

@AlanBateman No, it doesn't.

from java-almanac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.