Git Product home page Git Product logo

Comments (5)

marchof avatar marchof commented on June 5, 2024

Hi @AlanBateman thanks for your feedback! I had the same observation but did not find a proper solution yet. Filtering referenced types by their visibility is currently not really supported by my simple diff tool.

Instead of listing all permitted subclasses I could simply give a class a "sealed" tag if it declares at least one permitted subclass.

  • Pro: Very concise diff, new sealed classes can be easily spotted
  • Con: Change in list if permitted subclasses is not shown

For me this is a pragmatic solution which at least gives a quick overview. WDYT?

from java-almanac.

jnehlmeier avatar jnehlmeier commented on June 5, 2024

What about tags [+ sealed] or [- sealed] or [sealed: permits changed].

However I can already see someone asking to see the permits. Maybe opening permits in a modal view might be an option which does not cause trouble with the current list layout. So [+ sealed] and [sealed: permits changed] should be clickable then.

from java-almanac.

marchof avatar marchof commented on June 5, 2024

@jnehlmeier As of today these pages are statically rendered. Also it is all backed by an API which I need to consider when I do changes.

from java-almanac.

AlanBateman avatar AlanBateman commented on June 5, 2024

I don't think it's useful to list permitted subclasses that aren't accessible. In the API docs you'll see it includes "(not exhaustive)" when the permitted subclasses includes subclasses that aren't part of the API. If I read your comment correctly then this is not currently feasible with the diff tool. Okay, I was just providing feedback that recent diffs have noise. You mentioned printing "sealed" when the PermittedSubclasses attribute is present and that could be useful.

from java-almanac.

marchof avatar marchof commented on June 5, 2024

If I read your comment correctly then this is not currently feasible with the diff tool

Exactly. I process class by class and extract API information from it. For now I can't consider other classes (which would require building an index first). But indeed there are other use cases, for example #4.

from java-almanac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.