marcelo-ochoa / sqlcl-docker-extension Goto Github PK

Last commit fix zombies process when stop ttyd process when changing from dark/light mode.
Now is working properly but when Docker Desktop is configured in Dark mode I see than start post service is called twice:
2022/08/25 19:12:49 started ttyd with theme: {"background":"#F4F4F6","foreground":"#27343B","cursor":"#17191E","selection":"#6BC3F3"} 2022/08/25 19:12:49 started ttyd with theme: {"background":"#202C33","foreground":"#FFFFFF","cursor":"#C4D0DA","selection":"#6BC3F3"}
It seem that Docker Desktop first call start post service with light mode and immediately call again with dark setting.
When working in light mode this behavior is not experimented.
@benja-M-1 Did you have any idea of why this happen?
Marcelo.

Hi @marcelo-ochoa 👋

I was trying out the latest version and noticed that, with Docker Desktop in dark mode, the extension starts in light mode from time to time. Not sure it is related fully on #3. I mean, it would maybe prevent the issue to happen. But I was thinking that maybe it has to do with the fact that the extension starts in light mode, then switches dark mode. The first process being not fully started, the second one does not stop it. Which could cause issues.

CONTRIBUTING.md is a must read file for a new contributor in any repository before starting to work.

• Add general good practices while starting to work with this specific project.
• Add standard Github workflow commands in the CONTRIBUTING.md (opening issues, get assigned, fork, create clone, add, commit, creating PRs).
• It will provide new potential project contributors with a short guide to how they can help with your project.