marceljurtz / lifecounter Goto Github PK

Lifepoint-TextView is too far on the edges

It seems that a single click already resets the life counters. This is rather unfortunate as it can happen quick and haphazardly.
The requirement of a long click or a dialog asking for confirmation might mitigate this risk.

Players 2 & 4 not working

Points added / substracted which can be set in settings are not used by the poison counter.

I found your app on f-droid and tried to study/run the code on android-studio but got the following error

java.lang.RuntimeException: Unable to instantiate activity ComponentInfo{com.marceljurtz.lifecounter/com.marceljurtz.lifecounter.views.Game.GameActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.SharedPreferences android.content.Context.getSharedPreferences(java.lang.String, int)' on a null object reference

java.lang.NoClassDefFoundError:
at android.support.v7.app.AppCompatDelegateImplV7.initializePanelMenu(AppCompatDelegateImplV7.java:1194)
at android.support.v7.app.AppCompatDelegateImplV7.preparePanel(AppCompatDelegateImplV7.java:1258)
at android.support.v7.app.AppCompatDelegateImplV7.doInvalidatePanelMenu(AppCompatDelegateImplV7.java:1553)
at android.support.v7.app.AppCompatDelegateImplV7.access$100(AppCompatDelegateImplV7.java:89)
at android.support.v7.app.AppCompatDelegateImplV7$1.run(AppCompatDelegateImplV7.java:129)
at android.os.Handler.handleCallback(Handler.java:725)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:5285)
at java.lang.reflect.Method.invokeNative(Native Method:0)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1102)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:869)
at dalvik.system.NativeStart.main(Native Method:0)

Maybe throw dices by shaking the phone?

Implement classic settings activity with reset functionality, remove save / cancel buttons (replace by backwards navigation and reset button)

• Move activities to fragments
• Unclutter MVP-architecture

Users should be able to decide wether this feature is enabled or not.

• Break Build on Lint Errors
• Treat Warnings as Errors

include github + contact link

• Wrap up counter manager to always use 4 players, no matter what gamemode is currently active
• Add naming customization option for all for players
• Add an option to remove a player completely
• Add an option to remove a counter
• Add an option to increase / decrease a counters value. This should be possible in a quick, easy and intuitive way
• Add useful naming conventions on methods for view & presenter

Each player could have their name displayed on their side

see #18