mara / mara-metabase Goto Github PK

We do not have easy access to the commandline, so it would be nice to get a button somewhere to run the sync without triggering a pipeline run or so.

It was really surprising to me to see that this is quietly enabled by just setting up (=importing) mara_metabase. It would be nice if this could be disabled by default and only enabled by a config.

This just destroyed our metabase roles on prod. Our metabase is Not managed by the mara UI and after clicking the save on the UI after giving someone access all configured mara UI users were reset :-(

same problem as mara/mara-app#35: the .scripts folder is not in the pypi package.

Currently a composed metric gets the formula as display name but simple metrics default to the name as defined in the mara-schema:

https://github.com/mara/mara-metabase/blob/master/mara_metabase/metadata.py#L69

     'definition': {'source-table': table['id'],
                                         'aggregation': [
                                             metric_definition(_metric, table)
                                             if isinstance(_metric, SimpleMetric)
                                             else ['aggregation-options',
                                                   metric_definition(_metric, table),
                                                   {'display-name': _metric.display_formula()}
                                                   ]
                                         ]},

This means if you explore the dataset in metabase and summarize, you will have names as in the data dictionary for simply metrics but the formulas for composed metrics in parts of the graph. E.g. here the headline has the names, but the legend has the formula

Is that intended? If yes: would it be ok to make this configureable (without me vendoring /patching the whole metadata sync function?)

Some things would in my opinion be useful:

• Currently only predefined metrics are available but not the underlying columns for these metrics. Sometimes it would be nice to also use metrics in groupers and so on: it would be nice if there could be a way to not hide a column which is the base for a measure.
• Metabase has a field type, so it would be nice if this could be set based on what is in mara-schema. E.g. if mara-schema would gain a Type.QUANTITY mara/mara-schema#8 it would be nice if this could be mapped to the metabase field type 'Quantity' so these columns are not automatically set to 'Category' in some cases.

As mara-schema should probably not be specific to the viz layer after it, maybe all attributes/measures in mara-schema could get an optional label: Optional[dict] = None so that this could be passed through? E.g. labels={'mara-metabase':{'hide': False, 'field_type': 'Quantity'}}?