Git Product home page Git Product logo

Comments (2)

davidtheclark avatar davidtheclark commented on September 27, 2024

The specific reason I'm seeing this is one library (got) that conditionally calls require('electron') — but Webpack can't know that it doesn't need to bundle 'electron' in there. So I have a PR to add electron to the externals list during the static build, and maybe that will be enough to address this problem, at least for now.

from batfish.

davidtheclark avatar davidtheclark commented on September 27, 2024

I wonder if the only reason we can't use a regular, non-target: node Webpack build is because static-render-pages.js uses fs and path. If that's the case, a better long-term solution might be to revise the static build system so that those requirements exist outside the code that Webpack bundles up.

from batfish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.