manogi / nova-tiptap Goto Github PK

Not an issue but a proposal.

Is it possible to add title attributes to the buttons in the editor toolbar? So when you hover over each button a helpful hint shows. Much like the GitHub editor here:

Mock up using Chrome dev-tools:

Whilst many of us developers will recognise the editor icons, there are some clients (the ultimate the end user) who may not.

Your editor is really cool! It would be very nice to have support for the Nova 4 dependsOn() - Feature, for example to set a different default content in depending on a Select box.

Thanks a lot!

Hi Hans from Scrumpy here. I just discovered your laravel nova field, that's awesome!

We changed our org name to @scrumpy, there's an redirect set up but it could potentially be taken over. Would you mind to update the name in your README? 💓

https://nova.laravel.com/docs/3.0/resources/fields.html#default-values

Tiptap::make('Rules', 'rules')
    ->hideFromIndex()
    ->rules('nullable', 'min:5', 'max:5000')
    ->buttons(TipTapTrait::buttons())
    ->headingLevels(TipTapTrait::allHeadings())
//                ->resolveUsing(fn () => 'Manogi\Tiptap')
    ->default(fn () => 'default.'),

Following convention of all other Nova fields there should exist an id attribute on the element with tiptap-content class containing the name of the field.

Let me know if you need help with this.

Whenever I am trying to write "?" symbol, the global search gets the focus, so it seems there is conflict between laravel nova global search shortcut key.

Any idea how to fix this ?

Hello! 👋

I have an issue with the editor integration on a client site that I can't figure out.

When I go to the edit form of a page (one of my resources), I update the title for example then I save, and then one or more contents in one of the layouts will be saved at null.

I'm not sure if the issue comes from this package or from my code, anyone have an idea?
Maybe mixing with layouts classes from Flexible Content is an issue?
Maybe having multiple editors on the same form is a problem?

I use PHP 8.1, Laravel 9, Laravel Nova 4 and the Flexible Content package.

Can you tell me how to test it? Clone the repo and require it into my nova-components maybe ? That way I could use logs and Vue devtool ?

Below my layout class with the editor in it:

If this issue needs to be in the discussions let me know and I will move it. 👍

Is there any reason to have an empty detail field in 2.0?

With 1.0 all worked fine on my side :)

https://github.com/manogi/nova-tiptap/blob/v2.7.0/resources/js/components/DetailField.vue

isn't adding v1 vue component enough?

Hello,

Right now, when you delete an image from the field, it still stays on the drive.

Hi,

It would be great if this library allowed users to set the inline setting for the images extension. This is required if you want to allow images to be made linkable. From what i can see there is no way to set this currently.

https://tiptap.dev/api/nodes/image

I couldn't see in the documentation or code, but is there a way to add embeds, specifically YouTube?

Hi there,

Great package!

I wonder if it's possible to add your own extensions? Currently want to add superscript and subscript support, and I found this plugin for tiptap: https://github.com/hanspagel/tiptap-extension-superscript is there any way currently to make it work with this package? :)

Thanks!

I have a problem when installed, it's required for class Laravel\Nova\Nova

Hi! I was hyped using the package until I noticed that there isn't an option to centralize text, is it possible to add it?

On version 3.0.6:

Seems like the icon for the paragraph button is missing in NormalButton.vue.

By SEO and accessibility [and standards], it's better to have only one H1 per page. For this reason it will be nice to specify available headers as a range or a list, e.g. [3,4,5,6]. Is it possible right now? If now, can we have this feature in the package?

PS: thanks for your great package!

• download="" attribute wrongly applied to all links which is force the browser to download the page instead of navigating it.
• title="" applied to all links and can not modified by the editor which is not good for SEO.
• rel="noopener noreferrer nofollow" applied to internal links which is not good for SEO (would be best if we can choose the rel mode).

Add an option to always show the complete content.
Like in TextArea Field:

Textarea::make('Intro')->alwaysShow(),

Now that Nova 4 is out, it would be great if we could update this field to support it. Let me know if you would like some help on this and I may be able to dedicate some time on it. For this field I don't believe we will have too many changes to make.

Is there any way to add rtl support as well?

froala/nova-froala-field has a very useful (in some cases) mode to edit raw HTML. Is it possible to implement the same for this field/editor?

When using the TipTap editor, the label name is not showing on the details view.

In cases when you have more than one editor field per view, it can be a bit tricky to figure out which field is which.

Versions:

• Nova: 3.32.0
• TipTap: 2.8.8

Description

When pressing the link button the link modal is placed down in the bottom right just off the screen.

In the previous version 2.7.6 the modal is placed in the middle as expected.

Note in both versions then having more than TipTap field seems to result in the toolbars of each field on the screen appearing when the link modal is viewed.

Hi,

In edit html this is happening:

I'm using v1.4.1 and laravel nova v3.20.0.

When I select the link button the tooltip appears, but I cant select the input to type in a url. When I click the input it highlights like a button click. The close button works fine,

When I the link button.

When I click and hold the link form.

The file component upload works on this editor? How I can use it?

Thanks!

Just a small bug here. List items are being marked up to contain paragraphs on the details page:

code

Tiptap::make('Description')->hideFromIndex()->help(__('users.nova-help.description')),
Textarea::make('Notes', 'description')->hideFromIndex()->help(__('users.nova-help.description')),

result

version

v1.1.3

Error message with stacktrace:

vendor.js?id=952176bb1b228ba530bc:1 TypeError: Cannot read property 'replace' of null
    at a.parsedValue (tiptap:2)
    at hn.get (vendor.js?id=952176bb1b228ba530bc:1)
    at hn.evaluate (vendor.js?id=952176bb1b228ba530bc:1)
    at a.parsedValue (vendor.js?id=952176bb1b228ba530bc:1)
    at a.<anonymous> (tiptap:2)
    at a.t._render (vendor.js?id=952176bb1b228ba530bc:1)
    at a.hn.before (vendor.js?id=952176bb1b228ba530bc:1)
    at hn.get (vendor.js?id=952176bb1b228ba530bc:1)
    at new hn (vendor.js?id=952176bb1b228ba530bc:1)
    at vendor.js?id=952176bb1b228ba530bc:1

php I use:

            Tiptap::make('Description')
                ->hideFromIndex()
                ->help('User description visible for other users'),

[email protected]
Nova 3.10.0

Hey - if the tiptap field is used within an Action model then it is not selectable with a mouse or by tabbing into it.

It works fine when used on an update or creation page.

Latest nova & package version

You have probably considered it already and maybe rejected the idea, but a horizontal rule button would be useful in my case.

No big deal! Thanks for the package!

Is there possible to install it?
I really need button for change text color

Description

The <h4></h4>, <h5></h5> or <h6></h6> tags are converted to a <p></p> when while editing the content.

Example

During creation, my tags are properly formatted:

Wich is not the case when I'm editing the same content:

Is there any possibility to see the raw HTML that is getting stored when saving? I've seen this in a few editors - you could switch between WYSIWYG and the Sourcecode.

Hi,

Is it possible to implement the option new tab (target="_blank") to link?

Hi,

I'm trying to create a custom tiptap field for Nova (I can't use this package because I want to really customize it), but I can't get my code to build properly. When I try to import tiptap I get an 'unexpected token' error because of the usage of the spread operator. I finally found how to fix it, and that is upgrading Laravel-mix to 5.0, and adding a .babelrc in the root. This builds the files as expected.

However, the field is not showing. Not sure what is going on there. So my question is:

How can it work for you as the mix version in your package is 1.0? Shouldn't you be having the same issues? Or if you did, how did you fix it or what am I missing? I've spend almost 2 days now trying to get it to work and could use some help :-(

// .babelrc
{
    "plugins": ["@babel/plugin-proposal-object-rest-spread"]
}

console:

php:

version:
php 7.4.21
nova 4.21.0
tiptap 3.0.3

Hi manogi,

The image component upload works on this editor? Do you know how I can use it?

Thanks,
Bruno

Hi there,
Im not aure if its a Bug or this is on purpose but its not possible tlo set multiple headings of the same kind in one fiel.

So after setting for eg. the first h3 the and mark another line line the h3 Button is not working anymore?

When following the documentation and adding Tiptap::make('something'), I am presented with the following exception "class Manogi\Tiptap not found"

I declared the following dependency in the class:

use Manogi\Tiptap;

I also tried "use TipTap" and "Laravel\Nova\Fields\TipTap".

Any idea what could be the issue?

Hi,

When i activated the edit html option and add some html (<iframe> or <div>) and change to normal mode, the html is removed.
If i insert something like <p> or <h6> works nice.

I'm using v2.7.3 and laravel nova v3.20.0.

Is there any plans to support color coloring? Also text alignment would also be great.
Thanks

Could you add table support (https://tiptap.scrumpy.io/tables) at some point?

oh my god...
I saw this #3
but the tiptap https://github.com/ueberdosis/tiptap
alread has font color
ueberdosis/tiptap#1362
can you add it?
thanks

Any chance of supporting the YouTube node extension in the near future? I'm not familiar enough with custom fields in Nova yet to submit a PR but happy to spend some time reading up on them if this isn't already on your roadmap.

https://tiptap.dev/api/nodes/youtube

I can see this was added in version 1.1.1(?) in response to the following issue:
#25

The buttons show when added to the field, but don't appear to be working.

Have some updates from the following commit been lost in the latest version?
10ceb8e#diff-b1e358490779f68e26ce0c95ff13cbff5b677aa150dd26bc5cf20b066b765b7c

Hi Magoni,

First of all, thank you so much for this amazing package!

One small thing, I noticed that when deleting all the text inside the field editor, empty HTML tags are still saved on the database.

Things like <p></p> or <strong></strong>.

The problem is, when doing <?php if (empty($field)) echo 'something'; ?> is always going to give positive, because $field is never really "empty".

Laravel version: 8.83.0
Nova Version: 3.32
TipTap Version: 2.8.3

I'm facing an issue with link button that stopped working using the editor inside a laravel nova action modal.
When I click the button nothing is happening and the modal of Laravel nova action just reopen.