Git Product home page Git Product logo

mamori-i-japan-api's People

Contributors

daisuke-fukuda avatar daisukehirata avatar shogo-mitomo avatar tbnv999 avatar yashmurty avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

mamori-i-japan-api's Issues

Integration with react-native-exposure-notification-service mobile App.

Hi,

Planning to use this library to integrate with react-native-exposure-notification-service of our own app. I have couple of questions.

  1. can I use these APIs to integrate with the exposure notification service?
  2. is there any way I can import indexes and collection data structure to firestoreDB?
  3. is there any way I can create testing user to test these services?
  4. Is there any API I can use as keyServerUrl for the service?

Your input will really helpful.

--
Thanks in Advance,
Shashi

[API] /auth/admin/login(POST) response with a status code of 201 is returned.

Bug Details

  • The status code of the /auth/admin/login(POST) response is returned as 201 and the data is also returned.
    • By Swagger's definition, the status code is 204, with no response data.

covid-auth-admin-login

# Implementation environment * Postman(Mac)

Expected value

  • As defined in Swagger, the status code returns 204 as a response

Reproduction method

  1. Open an API test tool such as Postman and configure the following
  2. Enter the URL. https://api-dev.mamori-i.jp/auth/admin/login
  3. Obtain an access token from the authentication screen
  4. Set the access token obtained in 3 as the Bearer Token
  5. Send the API

[API] 実装の終わっていないAPI

実装の終わっていないAPI

実装の終わっていないAPIと完了時期を教えて下さい。
以下2つが終わっていない認識ですが、あってますか?

  • 陽性登録(保健所トークン申告)
    • swaggerに記載あり(/users/me/health_center_tokens)
  • 陽性判定の削除 (同意撤回)
    • swaggerに記載なし

陽性登録(保健所トークン申告)についての質問

healthCenterTokenは制限(DBにすでに存在するものなど)や、命名規則がありますか?

[feature] /v1/users/me/close_contacts

  • Uploading exposure(濃厚接触) temp IDs list for the past 14 days from the mobile to the backend when the user become positive.
  • user consent is required. optin, can be optout as well
  • only positives invoke this API.
  • the uploaded data will be used by mainly the cluster analysis team.

[API] /admins/positives(POST) response with a status code of 201 is returned.

Bug Details

  • The status code of the /admins/positives(POST) response is returned as 201.
    • By Swagger's definition, the status code is 204, with no response data.

covid-admins-positives

Implementation environment

  • Postman(Mac)

Expected value

  • As defined in Swagger, the status code returns 204 as a response

Reproduction method

  1. Open an API test tool such as Postman and configure the following
  2. Enter the URL. https://api-dev.mamori-i.jp/admins/positives
  3. Include the following in the Request body
{
  "phoneNumber": "+819078772537"
}
  1. Obtain an access token from the authentication screen
  2. Set the access token obtained in 3 as the Bearer Token
  3. Send the API

[API] APIs with different definitions of test results and swagger

APIs with different definitions of test results and swagger

The following is a summary of the results of the API unit test and the API with different definitions in swagger.
I think it's probably an omission in swagger, so please fix the definition.

  • /admins/users/(GET)
    • Success
      • accessControlList(l.5)(#/components/schemas/Admin)
  • /admins/users/{userId}(GET)
    • Success
      • accessControlList(l.28)(#/components/schemas/Admin)
    • Client Error
      • 404
        • usecase : invalid userId (l.30)
  • /admins/users/{userId}(DELETE)
    • Client Error
      • 404
        • usecase : invalid userId (l.34)
  • /admins/prefectures/(GET)
    • Success
      • accessControlList(l.59)(#/components/schemas/Prefecture)
  • /admins/prefectures/{prefectureId}(GET)
    • Success
      • accessControlList(l.63)(#/components/schemas/Prefecture)
    • Client Error
      • 404
        • usecase : invalid prefectureId (l.64)
  • /admins/prefectures/{prefectureId}(PATCH)
    • Client Error
      • 404
        • usecase : invalid prefectureId (l.68)

[API] /admins/organizations/{organizationId} (GET) API doesn't get the organization information for the organizationId passed as a parameter

Bug Details

In this API, the organization information of the administrator's target organization(28B41D0F) is obtained, not the organization information of the organizationId(448DC39B) passed as a parameter.
スクリーンショット 2020-05-07 17 32 13

Implementation environment

  • Postman(Mac)

Expected value

The organization information of the organizationId passed as a parameter is retrieved.

Reproduction method

Open an API test tool such as Postman and configure the following

  1. Enter the URL. https://api-dev.mamori-i.jp/admins/organizations?organizationId=448DC39B
  2. Obtain an access token from the authentication screen
  3. Set the access token obtained in 2 as the Bearer Token
  4. Send the API

[API] Passing a registered email address to the request body and executing the API(/admins/users(POST)) returns an status code(404).

Bug Details

  • Passing a registered email address to the request body and executing the API(/admins/users(POST)) returns an status code(404).
    • A status code (201) will be returned as well as an unregistered email address.

スクリーンショット 2020-04-23 9 01 03

# Implementation environment * Postman(Mac)

Expected value

  • The status code returns 201 as a response

Reproduction method

  1. Open an API test tool such as Postman and configure the following
  2. Enter the URL. https://api-dev.mamori-i.jp/admins/positives
  3. Include the following in the Request body (unregistered email)
{
  "email": "[email protected]"
}
  1. Obtain an access token from the authentication screen
  2. Set the access token obtained in 3 as the Bearer Token
  3. Send the API
  4. Send the API again.

[bug] Firebase dependency issue

I saw this strange error in the logs.
We might face this sooner or later.
We can investigate this later if we run in to it quite often. 🙏

2020-04-24T11:23:48.889Z	690de5f8-b3e5-4b4f-b238-0af7bf0c6d13	ERROR	Uncaught Exception 	
{
    "errorType": "Error",
    "errorMessage": "14 UNAVAILABLE: No connection established",
    "code": 14,
    "details": "No connection established",
    "metadata": {
        "internalRepr": {},
        "options": {}
    },
    "stack": [
        "Error: 14 UNAVAILABLE: No connection established",
        "    at Object.callErrorFromStatus (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/call.js:30:26)",
        "    at Object.onReceiveStatus (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:327:49)",
        "    at Object.onReceiveStatus (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:303:181)",
        "    at Http2CallStream.outputStatus (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:114:27)",
        "    at Http2CallStream.maybeOutputStatus (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:153:22)",
        "    at Http2CallStream.endCall (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:140:18)",
        "    at Http2CallStream.cancelWithStatus (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:441:14)",
        "    at ChannelImplementation.tryPick (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/channel.js:214:32)",
        "    at ChannelImplementation._startCallStream (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/channel.js:244:14)",
        "    at Http2CallStream.start (/opt/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:418:22)"
    ]
}

Found these related issues on github.
grpc/grpc-node#1064
googleapis/nodejs-pubsub#890

[API] /admins/organizations (POST) API can create an organization with the same name

Bug Details

The API in /admins/organizations (POST) was able to create an organization with the same name and the name was not checked for duplication.

Implementation environment

  • Postman(Mac)

Expected value

If an already registered name is POSTed, an error message such as "The organization name you entered is already registered" will be returned.

Reproduction method

Open an API test tool such as Postman and configure the following

  1. Enter the URL. https://api-dev.mamori-i.jp//admins/organizations
  2. Include the following in the Request body (unregistered email)
    { "name": "test organization", "message": "This is optional message. Can be later added via PATCH." }
  3. Obtain an access token from the authentication screen
  4. Set the access token obtained in 3 as the Bearer Token
  5. Send the API
  6. Send the API again.

[API] /auth/login(POST) response with a status code of 201 is returned.

Bug Details

  • The status code of the /auth/login(POST) response is returned as 201 and the data is also returned.
    • By Swagger's definition, the status code is 204, with no response data.

covid_api_auth_login_back

# Implementation environment * Postman(Mac)

Expected value

  • As defined in Swagger, the status code returns 204 as a response

Reproduction method

  1. Open an API test tool such as Postman and configure the following
  2. Enter the URL. https://api-dev.mamori-i.jp/auth/login
  3. Include the following in the Request body
{
  "prefecture": 1,
  "job": "公務員"
}
  1. Obtain an access token from the authentication screen
  2. Set the access token obtained in 3 as the Bearer Token
  3. Send the API

[API] Sending a request using the /users/me/profile (PATCH) API without a required request body, will return a status code of 200.

Bug Details

  • Sending a request with the /users/me/profile (PATCH) API without a request body will return a status code of 200
    • The status code (400) will be returned.

スクリーンショット 2020-05-05 16 08 18

Implementation environment

  • Postman(Mac)

Expected value

  • The status code returns 400 as a response.

Reproduction method

  1. Open an API test tool such as Postman and configure the following
  2. Enter the URL. https://api-dev.mamori-i.jp//users/me/profile
  3. Obtain an access token from the authentication screen
  4. Set the access token obtained in 3 as the Bearer Token
  5. Send the API

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.