makhanifahim / transaction-management Goto Github PK

Methods are unnecisarily long.
I shouldn't be scrolling to read a single method.

The lack of test makes this code base fragile and dangerus to work in.

There is no readme that describes what this service is for what the technologie is and a quickstart.

• Your aplication Class should be in a package.
• Inconsistent Class names.
• Format all classes.
• Logic in controller Class

The Data dir should not be part of the repo just like you would not upload the data dir of a DB.

The API is not documented considering that it is a REST API use the OpenAPI spec.

• The order of tests is not garenteed so you should not be relying on test 1 to set up for test 2
• use befor and after methods to setup and cleanup tests (don't leave clutter on the build system)
• tests should follow the structure: given (a state) when (a action is taken) then (the resulting state is)