mailersend / mailersend-ruby Goto Github PK

We added two parameters for our domains: ignore duplicated recipients and add a precedence bulk header. Both of these parameters have to be added to our related Domains endpoints.

• Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Get a list of domains endpoint.
• Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Get a single domain endpoint.
• Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Add a domain endpoint.
• Add the ignore_duplicated_recipients and the precedence_bulk parameters to the Update domain settings endpoint.

Expected behavior

Makes the API_TOKEN configurable through config file, hence the env variable name can be anything

Actual behavior

The only way to set the token now is through env variable, which might clash with another environment variable with the same name

Hi MailerSend! 👋 😄

Would you be open to making the dotenv an optional dependency so that it doesn't need to be loaded in production environments? It looks like it's only being used in a few places, but removing those without breaking the existing behavior for users of your gem who want to continue using dotenv might be tricky.

• Add the Get API quota endpoint
• Add it to the README
• Add it to the TOC.

• Remove all mentions of the simple personalization feature, replace with advanced personalization.

SMS endpoints

• #24
• #27
• #28
• #29
• #30
• #31

There is the add_tags method in the MailerSend::Email class but it does not seem to add tags to the email.

If you take the readme example code and add:

...
ms_email.add_tags('test-tag')

# Send the email
ms_email.send

It will not add a tag to the email.

Thanks!

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update dependency bundler to '~> 2.5.0'

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

• don't forget to add personalization

We recently added the in-reply-to option to the header.
Please include it in the SDK, under the Send an email endpoint. Documentation is here.

We have a new parameter called "inbound_priority" on our Inbound Routes. This parameter allows our users to create multiple inbound routes per inbound subdomain. Each one of the routes will be processed in a descending order. Values can be between 0 and 100. 0 has more importance than 100.

• Add the "inbound_priority" parameter on the "Add an inbound route" endpoint, on the request and the response.
• Add the "inbound_priority" parameter on the "Get a list of inbound routes" endpoint, on the request and the response.
• Add the "inbound_priority" parameter on the "Get a single inbound route" endpoint, on the request and the response.
• Add the "inbound_priority" parameter on the "Update an inbound route" endpoint, on the request and the response.

• Remove all mentions of the "processed" email event in the docs.

• Add the "Get a single sender identity by email" endpoint
• Add the "Update a sender identity by email" endpoint
• Add the "Delete a sender identity by email" endpoint
• Make sure to add all 3 endpoints to the Table of Content on the README.

Dotenv by default will look for a hierarchy of files, but using dotenv/load drops that to only look for .env.

Our app uses .env.local for dev machine environment variables that probably shouldn't be committed, but this doesn't get loaded if we're using mailersend-ruby. Is there a way to avoid the dotenv/load call somehow?

...via rspec and vcr.

The local variable response is not initialized in lib/mailersend/sender_identity/sender_identity.rb prior to being used in the last line of the list method:

    def list(domain_id: nil, page: nil, limit: nil)
      hash = {
        'domain_id' => domain_id,
        'page' => page,
        'limit' => limit
      }
      client.http.get(URI::HTTPS.build(host: API_BASE_HOST, path: '/v1/identities',
                                       query: URI.encode_www_form(hash.compact)))
      puts response
    end

This results in Mailersend::SenderIdentity.new.list throwing a NameError.

irb(main):014:0> Mailersend::SenderIdentity.new.list
Traceback (most recent call last):
        1: from (irb):14
NameError (undefined local variable or method `response' for #<Mailersend::SenderIdentity:0x0000aaaaf9ffe7c8>)
Did you mean?  respond_to?

Looks like the last line of the method, puts response, may have been from dev work and just needs to be removed to resolve this.

I do think that these lines can be interpreted by Ruby and sent through JSON to our API as an empty object or array. And in a case where a template_id is provided, and it has default settings, these are not required and are introducing an error.

This theory should be tested, however.

This is an example that breaks on the API side:

The documentation at https://developers.mailersend.com/api/v1/email.html#send-an-email does not specify any Limitations or details for the reply_to attribute while sending an email. After testing the ruby sdk multiple times, I think that the reply_to field only takes one value at a time, and on sending multiple values, it keeps on overwriting the previous value. This should be mentioned in the documentation I feel. I am ready to contribute in this way, since I also use the mailersend ruby sdk on a daily basis, but I couldn't find the documentation repository.

We recently changed activity fetch in our app so the pagination wasn’t working anymore for the API, could you update the Activity endpoint to match the most recent update?

I see the SenderIdentity#single_by_email method available albeit I didn't see it in the docs for this Ruby gem.

I have a use case where I may have the same email with two sender identities for two different signed/verified domains and I need to search by both email and domain_id to get the correct identity_id. Since the dataset is small, I can perform a linear search against the output of SenderIdentity#list, but this isn't a good long term solution.

Is there another endpoint where I can search by both email and domain_id? Or, if not, would it be possible to modify this method's target endpoint to include email and domain_id optionally?

    def single_by_email(email:)
      hash = {
        'email' => email
      }
      client.http.get(URI::HTTPS.build(host: API_BASE_HOST, path: "/v1/identities/email/#{email}",
                                       query: URI.encode_www_form(hash.compact)))
    end

As another option, maybe it would be possible to add a separate method, multiple_by_email or something to return an array of any with the email and then I can perform a search against the reduced data set.

Please add the following endpoints on the new Sender Identity section, below the Domains.

• Get a list of sender identities
• Get a single sender identity
• Add a sender identity
• Update a sender identity
• Delete a sender identity

• Get all email verification lists
• Get an email verification list
• Create an email verification list
• Verify an email list
• Get email verification list results

We should allow overriding base API url

https://github.com/mailersend/mailersend-go/blob/main/mailersend.go#L15