maibornwolff / dd-import Goto Github PK

if self.environment.build_id is not None or \
           self.environment.commit_hash is not None or \
           self.environment.commit_hash is not None:

I believe the last check should be self.environment.branch_tag shouldn't it?

Hi, I developed a workaround to set extra headers on the request to defect dojo for the reason that I cannot make requests directly to Defect Dojo because it is behind a Zero Trust solution that requires authentication, it is useful for me and I guess it will be a common deployment scenario.

DD_EXTRA_HEADER_1
DD_EXTRA_HEADER_1_VALUE

DD_EXTRA_HEADER_2
DD_EXTRA_HEADER_2_VALUE

So I opened this pull request: #101

Hi folk,

I dont know how to make a pull request here.

From API ver 2.30.2, they remove the APIv2 and pump to APIv2 OA3.
We should change from;
https://github.com/MaibornWolff/dd-import/blob/main/dd_import/dd_api.py#L43
/api/v2/
to
/api/v2/oa3/

Thanks

Hi Team,

Thank you for all your work on this tool. I was wondering why the engagement end date for engagements created by the import are defaulted to the year 2999, I am new to DefectDojo and was wondering if this was a best practice or intended workflow for CI/CD engagements. I see the code here is where these values are being defined https://github.com/MaibornWolff/dd-import/blob/main/dd_import/dd_api.py#L103-L104, happy to put in a PR to make these environment variables as it serves my use case but was looking for more insight into why this was setup this way.

Best,
J

Hi, firstly, thank you for creating and maintaining this project.

I'd like to request a feature: project types are created automatically, if they are missing.

I'm using GitLab groups as Product Types. My users like to create new groups regularly. It would be great if this synced automatically.

If you are fine with this idea, I'm happy to contribute appropriate changes.