mahmutkaya / hyf-javascript1 Goto Github PK

Hi Mahmut,

Here is my feedback on your homework.

• You created your JavaScript files in the root folder of your Git repo. Please create a folder week2 and move your homework .js files to that folder. And the same, for week3 when we get there.

1-hello

• The console.log statements should not be indented here.

2-finding error

• Spaces in file names are often problematic. Best to avoid it. Instead use a name such as findind_error.js or findingError.js, as you did for moreStrings.js.

3-variable

• You should not have more than one blank line at the end of your file.

6-arrays

• We may have confused you guys with the word ‘plurality’. We meant that the variable name (which was yours to choose) was in plural form, as for instance you did with kings, which is the plural form of the singular king. But you got the idea anyway.
• Please be consistent in your use of uppercase and lowercase. If you use lowercase for "lion" and "rooster" then also use lowercase for "eagle".

8-typeOf

• Because you used OR (||) operators the message "SAME TYPE" is printed if one or more comparisons hold true. For instance, if I change the value of b from "1" to 1 I get "SAME TYPE", although the other values are still of a different type. In this case it is better to have multiple if statements, each one comparing one set of variables.
• Use the triple form of === instead of ==.

9-Modulus

• This seems to be an exact copy of Kemirdin's homework.

10-multi

• Except for some trivial changes, this again looks like a copy of Kemirdin's work.

Overall your code looks fine, well-formatted. But why is there this similarity of the last two assignments with Kemirdin's work?

Hi Mahmut !
Your code is clear and readable. Your code works and I couldn`t find any mistakes. You are doing a good job. thumbsup smile