magnetme / consultant Goto Github PK

View Code? Open in Web Editor NEW

39.0 39.0 13.0 185 KB

A library to retrieve your service's configuration from Consul, and subscribe to changes.

License: Apache License 2.0

Java 100.00%

consultant's Issues

Consultant tries to retrieve directories as key-value's

...results in a NPE

How to reproduce:

open the consul UI
create a directory "/config/opengraph"
create a key "/config/opengraph/cache.lifetime" with some value

@michaeldejong

Readme is misleading with regards to withConsulHost

The README implies that using withConsulHost without a port, will default to 8500, which is not the case.

Request: support the `X-Consul-Token` request header for authentication

Would allow to authenticate via custom header to locked down Consul environments.

Request: Allow to write to the Consul KV store

Allow to update a specific key with a value.
A method on the consultant client like

consultant.setConfig(String fullKeyPath, String keyValue)

Would require a check, that only keys and not folders are allowed to write. (no slash at the end of the fullKeyPath)

Defining port different than 8500

Hi,

Have you ever thought to put in Consultant builder a way to define port different than 8500 ? Thanks in advance!

ConfigUpdate throws NPE on KV nested keys.

as soon as a key has been created in the KV store for the registered service without a value, consultant starts throwing NullPointerExceptions repeatedly:

consultant version: 1.7.4
consul version: 1.0.2

2018-01-05T14:27:37,426Z ERROR [pool-1-thread-1]         me.magnet.consultant.ConfigUpdater       - Error occurred while retrieving/publishing new config from Consul: null
java.lang.NullPointerException: null
	at java.util.Base64$Decoder.decode(Base64.java:549) ~[na:1.8.0_121]
	at me.magnet.consultant.ConfigUpdater.updateConfig(ConfigUpdater.java:172) ~[consultant-1.7.4.jar:na]
	at me.magnet.consultant.ConfigUpdater.run(ConfigUpdater.java:105) ~[consultant-1.7.4.jar:na]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_121]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_121]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_121]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [na:1.8.0_121]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_121]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_121]
	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_121]

The config response for my KV is:

[
    {
        "LockIndex": 0,
        "Key": "config/phoenix-app-local/networks/network01",
        "Flags": 0,
        "Value": "MTIz",
        "CreateIndex": 19,
        "ModifyIndex": 24
    },
    {
        "LockIndex": 0,
        "Key": "config/phoenix-app-local/networks/network02",
        "Flags": 0,
        "Value": "YWJjCmNkZQ==",
        "CreateIndex": 21,
        "ModifyIndex": 21
    },
    {
        "LockIndex": 0,
        "Key": "config/phoenix-app-local/failing-key",
        "Flags": 0,
        "Value": null,
        "CreateIndex": 26,
        "ModifyIndex": 26
    }
]

Means the issue occurs for keys which don't have a value set "config/phoenix-app-local/failing-key"

magnetme / consultant Goto Github PK

consultant's People

Contributors

Stargazers

Watchers

Forkers

consultant's Issues

Consultant tries to retrieve directories as key-value's

Readme is misleading with regards to withConsulHost

Request: support the `X-Consul-Token` request header for authentication

Request: Allow to write to the Consul KV store

Defining port different than 8500

ConfigUpdate throws NPE on KV nested keys.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent