magneticresonanceimaging / mrifieldmaps.jl Goto Github PK

There is an instance where you have echotime * scalar:

There is also an instance of echotime * vector':

outerproduct(echotime::AbstractArray, df) = echotime*df'
outerproduct(echotime::Tuple, df) = [TE * df for TE in echotime, df in df]

With the current definition of Echotime, one can't pass in a Tuple with various element types, so, e.g., (0, 2.3) will throw an error. This is because of the <: in NTuple{N,<:T}; removing <: would allow for (0, 2.3).

Not sure if you intended to force all the types of the Tuple elements to be the same, but if not, it should be an easy change.

The initial commit is designed mostly to reproduce the results in Julia from https://github.com/ClaireYLin/regularized-field-map-estimation

Planned improvements:

• refine data (or weight) scaling in b0scale using new derivations
• store initial cost and then cost after each update in b0map when in track mode
• validate gradient / cost consistency using autodiff
• more in-place operations?
• factor the b0map code into smaller units
• ultimately the nonlinear CG with monotone line search could be generalized and useful elsewhere
• request that lldl support units (unlikely). so perhaps use reinterpret?
• timing test for whole-brain 2mm isotropic, e.g., 112 x 112 x 72
• https://github.com/korbinian90/ROMEO.jl for unwrapping

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!