Comments (11)
Hi @Kashyap1999
Thank you for reporting and collaboration.
Verified the issue on Magento 2.4-develop instance and the issue is confirmed as the product videos are not played and not showing any errors in the console on mobile devices.
Please refer the attached video evidences.
video.mov
Thanks
from magento2.
I've had the same issue and through investigation I've created the following patch. This resolves the issue for the 2.4.6-p3 site I'm working on, with the other Fotorama fixes (#37355 and #36578) also applied as patches.
38137-fotorama-mobile-videos-slider.patch
Essentially the fix is to remove the following line:
magento2/lib/web/fotorama/fotorama.js
Line 1484 in c333d32
This seems to have stemmed from the change in the addEvent
function applying the bool
argument to the passive
option for addEventListener
, instead of the useCapture
argument as it previously did. Referencing: 3598333
This feels like more of a 'workaround' than a full solution and therefore may require a more robust/better approach. However, I haven't experienced any problems/different behaviour when testing the patch in Chrome, Firefox or Safari.
from magento2.
Thank you! I tested your fix. It's working, but we have another issue that related to this:
(The click/tap goes through)
#34886
If I use this fix and your fix. The issue of "Close button" returns again.
Perhaps the whole thing really should be looked at more closely and fixed. This is just for information, so that other problems can be looked at in context.
from magento2.
Hi @Kashyap1999. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release- For more details, review the Magento Contributor Assistant documentation.
- Add a comment to assign the issue:
@magento I am working on this
- To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
from magento2.
Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
- 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
- 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
- 3. Add
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to. - 4. Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! - 5. Add label
Issue: Confirmed
once verification is complete. - 6. Make sure that automatic system confirms that report has been added to the backlog.
from magento2.
Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
-
- Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
-
- Verify that issue has a meaningful description and provides enough information to reproduce the issue.
-
- Add
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.
- Add
-
- Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
- Verify that the issue is reproducible on
- Join Magento Community Engineering Slack and ask your questions in #github channel.
from magento2.
@magento give me 2.4-develop instance
from magento2.
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.
from magento2.
Hi @engcom-Dash, here is your Magento Instance: https://c161bc48363ce357765b749073a58421.instances-prod.magento-community.engineering
Admin access: https://c161bc48363ce357765b749073a58421.instances-prod.magento-community.engineering/admin_9cb6
Login: 3d03a5c4
Password: 61e8a4449877
from magento2.
✅ Jira issue https://jira.corp.adobe.com/browse/AC-10317 is successfully created for this GitHub issue.
from magento2.
✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
from magento2.
Related Issues (20)
- [Issue] update admin configuration visibility
- [Issue] Stop flushing fpc when not asked for HOT 3
- [Performance] Load reCaptcha on focus to input to improve page load times HOT 5
- [Issue] Remove Varnish 4/5 support HOT 4
- [Issue] Fix already merged PR 37477 : After changing "foreach" to "for", the "return" broke the function logic HOT 5
- Updating time of Date and Time type product attributes via CSV import HOT 3
- "Same as Billing Address" Checkbox not always visible in Admin Create Order Screen HOT 7
- Cart isn't active issue - Creating duplicate orders HOT 3
- [Issue] [vcl] don't manually interfere with compression HOT 5
- Pagebuilder Minimum Height acting as both Minimum and Maximum HOT 15
- About deleting license copyright comments in .html files HOT 1
- CSS minifiying sometimes results in blank CSS file due to PREG_JIT_STACK_LIMIT_ERROR in tubalmartin/cssmin HOT 8
- Animated gif not working HOT 23
- Missing indexing of required columns in catalog_product_entity_int table HOT 3
- Set Generate "category/product" URL Rewrites to "no" has no effect HOT 13
- Coupon usage limits not honored HOT 7
- Sales order item table, qty_backordered not set for configurable products HOT 9
- Currency not convert in new product widget without cache clean HOT 26
- Getting Database CPU usages high (100%) suddenlly HOT 7
- Configurbale Product update child product saving qty move issue HOT 24
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2.