CSS minifiying sometimes results in blank CSS file due to PREG_JIT_STACK_LIMIT_ERROR in tubalmartin/cssmin about magento2 HOT 12 CLOSED

The bug is still happening. It is not because of third party modules but rather in certain cases of CSS.

from magento2.

Why is this ticket closed? This is happening today.

from magento2.

Hi @nahall. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

from magento2.

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• Join Magento Community Engineering Slack and ask your questions in #github channel.

from magento2.

@magento give me 2.4-develop instance

from magento2.

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

from magento2.

Hi @engcom-Dash, here is your Magento Instance: https://34dd16ce2d6b21223b86a148b078666d.instances-prod.magento-community.engineering
Admin access: https://34dd16ce2d6b21223b86a148b078666d.instances-prod.magento-community.engineering/admin_5b3b
Login: e3c315f8
Password: 30a9a585e723

from magento2.

Hi @nahall

Thanks for reporting and collaboration.

Verified the issue on magento develop instance and issue is not reproducible.

We have followed the below steps to reproduce:

1. Log in to your Magento 2 admin panel
   2.Navigate to Stores>Configuration
   3.Go into the advanced tab and then the developer tab under configuration.
   4.Go to CSS settings and set the minify option to ‘Yes'

The CSS is minified. properly. Please refer the attached screenshot.

from magento2.

This does not fail with the stock Magento CSS but only in certain cases.

Since the problematic regexp in the CSS minifier is:

    $css = preg_replace_callback(
        '/(?:"(?:[^\\\\"]|\\\\.|\\\\)*")|'."(?:'(?:[^\\\\']|\\\\.|\\\\)*')/S",
        array($this, 'processStringsCallback'),
        $css
    );

It seems likely that the CSS needs to contain a number of quotation marks in order to encounter the problem.

from magento2.

Hi @nahall

Thanks for reporting and collaboration.

Can you please check if you are using any third party modules and try to reproduce the issue by disabling one by one.
Please let us know if you are still facing the issue.

Thanks

from magento2.

Hi @nahall

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

from magento2.

Here is workaround: tubalmartin/YUI-CSS-compressor-PHP-port#66 (comment)

from magento2.