magento / adobe-ims Goto Github PK

Adobe open source office review was done here.

Copying over details:

• Please add a CONTRIBUTING.md file to the repo. There's a generic Magento template available here that you can copy over and customize. The Adobe CLA and code of conduct language must remain, though.
• Please add a COPYING.txt to the repo.

This repository is missing the tag 2.2.0 containing magento/module-admin-adobe-ims version 100.5.0

The last tag 2.1.3-p3 was made two days ago, but that tag doesn’t contain the code for the modules AdminAdobeIms and AdminAdobeImsTwoFactorAuth.

Compare the develop branch and the 2.1.3-p3 tag.

Is there a chance to get a tag that points to the code that was used for Magento 2.4.6?

Steps to reproduce (*)

Construct a package dependency graph for Magento 2.4.3 and 2.3.1-p1 based on the public repositories in https://github.com/magento

Expected result (*)

All required dependencies can be satisfied by inspecting the appropriate tags.

Actual result (*)

The magento/adobe-ims package source for 2.1.2 is not publicly available in this repository.
Maybe someone forgot to do a git push --tags?

Preconditions (*)

1. Magento 2.4-develop with Adobe Stock Integration - 2.0-master and IMS - 2.0-master
2. Cloud - Magento ver. 2.4.0-p1
3. Configured integration in Stores -> Configuration -> Advanced-> System -> Adobe Stock Integration fieldset
4. Enhanced Media Gallery Enabled
5. Image added to Adobe Stock profile in the https://account.adobe.com/

Steps to reproduce (*)

1. Go to Content - Media Gallery
2. Click on the "Search Adobe Stock" button
3. Click "Sign in"

Expected result (*)

Image displays next to account name in the Adobe Stock

Actual result (*)

Image isn`t displays next to account name in the Adobe Stock

Additional details:
Profile image url is not saved to adobe_stock_profile table in the database

Error in the exception.log
Notice: Undefined offset: 276 in /app/vendor/magento/module-adobe-ims/Model/GetImage.php on line 74

This issue is a root cause for Adobe Stock Integration issue: magento/adobe-stock-integration#1851

Preconditions (*)

1. Magento and Adobe IMS are installed
2. API Key is configured for Adobe IMS
3. Have a valid user Access Token

Steps to reproduce (*)

Initiate a call \Magento\AdobeIms\Model\GetImage::execute method to retrieve user profile image

Also, see steps for Adobe Stock Integration issue: magento/adobe-stock-integration#1851

Expected result (*)

The user profile image is retrieved

Actual result (*)

The call for user profile image to Behance API https://cc-api-behance.adobe.io/v2/users/me?api_key=#{api_key} is rejected with 403003 Api Key is invalid error.

Jira ticket: https://jira.corp.magento.com/browse/MC-38529

The following interfaces and blocks should be marked as API

AdobeImsApi/Api/LogInInterface.php
AdobeImsApi/Api/LogOutInterface.php
Magento\AdobeIms\Block\Adminhtml\SignIn

The fix should target future-develop branch

The package magento/product-community-edition:2.4.4-p5 requires magento/adobe-ims:2.1.3-p5.

The package magento/adobe-ims:2.1.3-p5 is available on repo.magento.com, but there is no matching tag in this git repository.

Could you please add it?

Preconditions (*)

This github repo in state it is at the time or writing.

Steps to reproduce (*)

Try to check out the repository in the state of package magento/adobe-ims:2.1.3-p5.

Expected result (*)

Being able to inspect the code for 2.1.3-p5 in the repository

Actual result (*)

Tag 2.1.3-p5 not found.