magento-sparta / magento2docker Goto Github PK

The issue is about how a current session is looked for. If session names are like abc, abc-1, abc-2, then grep -i abc can give an incorrect result as all of those will pop out.

Possible solutions:

• to store session ID and not use grep for its name
• to fix grep e.g., check for the exact match in the whole line

When two instances are placed in the folders with the same name docker will mess up with them. To fix it we need to use the COMPOSE_PROJECT_NAME variable which should be unique.

SSL support for WWW traffic should be added to the current Apache implementation (but also future implementations like php-fpm, nginx, etc. should also support SSL).

The plan is to have https://github.com/yvoronoy/magento2docker as a public repository for this project, where we will not put features that are Adobe's internal things. For such internal modifications, we will use the https://github.com/magento-sparta/magento2docker repository.

Things we need to separate:

• m2install.sh - use Sparta repo for internal and Yvoronoy's for public
• use separate .m2install.conf files and default values for the .env file with repository address
• m-it - add it only in the Sparta repo, as it is not accessible from outside of Adobe

Current Apache configuration has this kind of domain-to-folder mapping:

Level 1:
{FOLDER}.127.0.0.1.nip.io -> /var/www/html/{FOLDER}

Level 2:
{SUB_FOLDER}.{FOLDER}.127.0.0.1.nip.io -> /var/www/html/{FOLDER}/{SUB_FOLDER}

The idea is to allow multi-domain setups enabled and configured by default in this way:

Level 1:
{FOLDER}.127.0.0.1.nip.io -> /var/www/html/{FOLDER}

Level 2:
{WEBSITE}.{FOLDER}.127.0.0.1.nip.io -> /var/www/html/{FOLDER}

This configuration is more beneficial for day-to-day issues reproduction.
Together with this, we can include magento-vars.php as default, like in a Cloud environment (directly in php.ini)

Add a new m2d command e.g. m2d go home that will cd into the m2d root directory.

This will simplify scenarios e.g. when we quickly need to edit .env file.

Add setup option if add m2d to the $PATH.

Add cloud-dump command to the Adobe tools:

Repository: https://git.corp.adobe.com/magento-support/cloud-tools

The Command must be available as a cloud-dump to be aligned with Sparta.