magento-engcom / php-7.2-support Goto Github PK

Repository for implementing support of php-7.2 support in Magento

License: Open Software License 3.0

PHP 78.35% JavaScript 8.46% HTML 9.43% CSS 3.73% VCL 0.02% Shell 0.01%

php-7.2-support's Introduction

Welcome

Welcome to Magento 2 installation! We're glad you chose to install Magento 2, a cutting edge, feature-rich eCommerce solution that gets results.

Magento system requirements

Install Magento

To install Magento, see either:

Magento DevBox, the easiest way to get started with Magento.
Installation guide

Contributing to the Magento 2 code base

Contributions can take the form of new components or features, changes to existing features, tests, documentation (such as developer guides, user guides, examples, or specifications), bug fixes, optimizations, or just good suggestions.

To learn about how to make a contribution, click here.

To learn about issues, click here. To open an issue, click here.

To suggest documentation improvements, click here.

Labels applied by the Magento team

Label	Description
	Affects Documentation domain.
	Affects the Product team (mostly feature requests or business logic change).
	Affects Architect Group (mostly to make decisions around technology changes).
	The pull request has been accepted and will be merged into mainline code.
	The pull request has been rejected and will not be merged into mainline code. Possible reasons can include but are not limited to: issue has already been fixed in another code contribution, or there is an issue with the code contribution.
	The Magento Team has confirmed that this issue contains the minimum required information to reproduce.
	The Magento Team has validated the issue and an internal ticket has been created.
	The internal ticket is currently in progress, fix is scheduled to be delivered.
	The Magento Team needs additional information from the reporter to properly prioritize and process the issue or pull request.

To learn more about issue gate labels click here

Reporting security issues

To report security vulnerabilities in Magento software or web sites, please e-mail [email protected]. Please do not report security issues using GitHub. Be sure to encrypt your e-mail with our encryption key if it includes sensitive information. Learn more about reporting security issues here.

Stay up-to-date on the latest security news and patches for Magento by signing up for Security Alert Notifications.

License

Each Magento source file included in this distribution is licensed under OSL 3.0 or the Magento Enterprise Edition (MEE) license

http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) Please see LICENSE.txt for the full text of the OSL 3.0 license or contact [email protected] for a copy.

Subject to Licensee's payment of fees and compliance with the terms and conditions of the MEE License, the MEE License supersedes the OSL 3.0 license for each source file. Please see LICENSE_EE.txt for the full text of the MEE License or visit http://magento.com/legal/terms/enterprise.

php-7.2-support's People

Contributors

Stargazers

Watchers

php-7.2-support's Issues

Broken integration test Magento\Catalog\Helper\Product\ViewTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

18) Magento\Catalog\Helper\Product\ViewTest::testPrepareAndRender
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection/Interceptor.php:1051
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php:126
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php:140
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/Product/Index/AbstractIndex.php:199
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Observer/CatalogProductViewObserver.php:79
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/View.php:278
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/ViewTest.php:108

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577321#L1378

Failing unit test Magento\Framework\Code\Test\Unit\Generator\InterfaceGeneratorTest

Magento\Framework\Code\Test\Unit\Generator\InterfaceGeneratorTest::testGenerate with data set "Valid data" (array(), '', '')
Interface was generated incorrectly.
Failed asserting that '<?php\n
/**\n
 * Copyright © Magento, Inc. All rights reserved.\n
 * See COPYING.txt for license details.\n
 */\n
\n
/**\n
 * @codingStandardsIgnoreStart\n
 * Coding Standards have to be ignored in this file, as it is just a data source for tests.\n
 */\n
\n
namespace Magento\SomeModule\Model;\n
\n
use Magento\SomeModule\Model\Two\Test as TestTwo;\n
use Magento\SomeModule\Model\Three\Test as TestThree;\n
\n
/**\n
 * Interface short description.\n
 *\n
 * Interface long\n
 * description.\n
 *\n
 * @tag1 data1\n
 * @tag2 data2\n
 */\n
interface SevenInterface extends \Magento\Framework\Code\Generator\CodeGeneratorInterface\n
{\n
\n
    /**\n
     * Method short description\n
     *\n
     * @param array $data\n
     * @return TestThree\n
     */\n
    public static function testMethod1(array &$data = array());\n
\n
    /**\n
     * Method short description\n
     *\n
     * Method long\n
     * description\n
     *\n
     * @param string $data\n
     * @param bool $flag\n
     */\n
    public function testMethod2($data = 'test_default', $flag = true);\n
\n
    public function testMethod3();\n
\n
\n
}\n
' ends with "namespace Magento\SomeModule\Model;
use Magento\SomeModule\Model\Two\Test as TestTwo;
use Magento\SomeModule\Model\Three\Test as TestThree;
/**
 * Interface short description.
 *
 * Interface long
 * description.
 *
 * @tag1 data1
 * @tag2 data2
 */
interface SevenInterface extends \Magento\Framework\Code\Generator\CodeGeneratorInterface
{
    /**
     * Method short description
     *
     * @param array $data
     * @return TestThree
     */
    public static function testMethod1(array &$data = []);
    /**
     * Method short description
     *
     * Method long
     * description
     *
     * @param string $data
     * @param bool $flag
     */
    public function testMethod2($data = 'test_default', $flag = true);
    public function testMethod3();
}
".
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Code/Test/Unit/Generator/InterfaceGeneratorTest.php:96

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577316

Deprecated: Function create_function() is deprecated

Deprecated: Function create_function() is deprecated on PHP 7.2

Returning void on method makes the whole class unable to use plugins

Important: use 2.3-develop as a target branch.

Steps to reproduce

Create a class with a void return type:

class MyClass {
    public function myFunction(): void
    {
        // do something
    }
}

Create a plugin for the class.

Expected result

Plugin should work correctly.

Actual result

It actually has a return statement in the plugin and it doesn't have the return type void.

Fatal error: A void function must not return a value in /data/web/magento2/dev/tests/integration/tmp/sandbox-0-77789c881f346521512f1309f07ad08b/generated/code/ReachDigital/ProophEventStore/Infrastructure/CommandBus/Interceptor.php on line 24

Call Stack:
    0.0002     352328   1. {main}() /data/web/magento2/vendor/phpunit/phpunit/phpunit:0
    0.0515    1523360   2. PHPUnit\TextUI\Command::main() /data/web/magento2/vendor/phpunit/phpunit/phpunit:53
    0.0515    1523472   3. PHPUnit\TextUI\Command->run() /data/web/magento2/vendor/phpunit/phpunit/src/TextUI/Command.php:141
   50.0469   48418624   4. PHPUnit\TextUI\TestRunner->doRun() /data/web/magento2/vendor/phpunit/phpunit/src/TextUI/Command.php:212
   50.0548   48644672   5. PHPUnit\Framework\TestSuite->run() /data/web/magento2/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:537
   55.6931   70004224   6. PHPUnit\Framework\TestSuite->run() /data/web/magento2/vendor/phpunit/phpunit/src/Framework/TestSuite.php:744
   55.6959   70004736   7. ReachDigital\ProophEventStore\Test\Integration\Command\RegisterUserTest->run() /data/web/magento2/vendor/phpunit/phpunit/src/Framework/TestSuite.php:744
   55.6959   70004736   8. PHPUnit\Framework\TestResult->run() /data/web/magento2/vendor/phpunit/phpunit/src/Framework/TestCase.php:883
   55.7131   67091784   9. ReachDigital\ProophEventStore\Test\Integration\Command\RegisterUserTest->runBare() /data/web/magento2/vendor/phpunit/phpunit/src/Framework/TestResult.php:695
   55.7136   67108424  10. ReachDigital\ProophEventStore\Test\Integration\Command\RegisterUserTest->runTest() /data/web/magento2/vendor/phpunit/phpunit/src/Framework/TestCase.php:928
   55.7136   67108720  11. ReflectionMethod->invokeArgs() /data/web/magento2/vendor/phpunit/phpunit/src/Framework/TestCase.php:1069
   55.7136   67108728  12. ReachDigital\ProophEventStore\Test\Integration\Command\RegisterUserTest->command_and_event_bus_are_correctly_instantiated() /data/web/magento2/vendor/phpunit/phpunit/src/Framework/TestCase.php:1069
   55.7136   67108728  13. ReachDigital\ProophEventStore\Test\Integration\Command\RegisterUserTest->commandBusInstance() /data/web/magento2/app/code/ReachDigital/ProophEventStore/Test/Integration/Command/RegisterUserTest.php:53
   55.7222   67675464  14. Magento\TestFramework\ObjectManager->create() /data/web/magento2/app/code/ReachDigital/ProophEventStore/Test/Integration/Command/RegisterUserTest.php:42
   55.7222   67675464  15. Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() /data/web/magento2/vendor/magento/framework/ObjectManager/ObjectManager.php:56
   55.7227   67692088  16. Magento\Framework\ObjectManager\Definition\Runtime->getParameters() /data/web/magento2/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:48
   55.7227   67692088  17. Magento\Framework\Code\Reader\ClassReader->getConstructor() /data/web/magento2/vendor/magento/framework/ObjectManager/Definition/Runtime.php:44
   55.7227   67692200  18. ReflectionClass->__construct() /data/web/magento2/vendor/magento/framework/Code/Reader/ClassReader.php:19
   55.7227   67692392  19. spl_autoload_call() /data/web/magento2/vendor/magento/framework/Code/Reader/ClassReader.php:19
   55.7227   67692488  20. Magento\Framework\Code\Generator\Autoloader->load() /data/web/magento2/vendor/magento/framework/Code/Reader/ClassReader.php:19
   55.7227   67692488  21. Magento\Framework\Code\Generator->generateClass() /data/web/magento2/vendor/magento/framework/Code/Generator/Autoloader.php:35
   55.7253   67709752  22. Magento\Framework\Code\Generator\Io->includeFile() /data/web/magento2/vendor/magento/framework/Code/Generator.php:118

Update PHP version dependency to ~7.2.0

Update composer.json to add PHP ~7.2.0:

root composer.json and composer.lock
module's and frameworks' composer.json - remove PHP requirement (ex: https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/AdminNotification/composer.json#L5)
dev/tests/functional/composer.json

AC:

use require-dev section, so Magento doesn't claim PHP 7.2 support until it's fully implemented and verified
existing tests (on PHP 7.1) are green

Broken integration test Magento\Catalog\Helper\Product\CompareTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

15) Magento\Catalog\Helper\Product\CompareTest::testGetListUrl
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:287
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:149
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/CompareTest.php:33

16) Magento\Catalog\Helper\Product\CompareTest::testGetItemCollection
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:287
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/CompareTest.php:91
17) Magento\Catalog\Helper\Product\CompareTest::testCalculate
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:320
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:341
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:354
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/CompareTest.php:107

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577321#L1336

magento/composer does not support PHP 7.2

Update https://github.com/magento/composer, so it supports PHP 7.2

Repo: https://github.com/magento-engcom/magento-composer-php-7.2-support

AC:

https://github.com/magento-engcom/magento-composer-php-7.2-support/blob/engcom-master/composer.json#L11 includes ~7.2.0
Setup scenarios pass on PHP 7.2 installation

Scenarios:

Web Setup Wizard: list, update, install an extension
Web Setup Wizard: upgrade Magento application to the next version
Magento CLI setup:install
Magento CLI setup:upgrade
Magento CLI module:enable
Magento CLI module:disable
Cloud setup/deployment

Broken unit tests

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577316

See issues in the epic.

Other tests will be fixed in the scope of:

#10
#7
#4 (requires Symfony upgrade to a major version, which causes tests failure due to removed Symfony classes)
#9

Broken integration test Magento\Multishipping\Controller\CheckoutTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

1) Magento\Multishipping\Controller\CheckoutTest::testOverviewAction
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:154
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:316
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/Product/Compare/Item.php:192
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Observer/Compare/BindCustomerLoginObserver.php:35
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/Session.php:435
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/Session/Interceptor.php:232
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Multishipping/Controller/CheckoutTest.php:58

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1090

"Object" as class name

The object name was previously soft-reserved in PHP 7.0. This is now hard-reserved, prohibiting it from being used as a class, trait, or interface name.

"Object" as class name is found in the data provider of \Magento\Framework\Code\Reader\SourceArgumentsReaderTest integration test.

Travis CI configuration with PHP 7.2 support

Update Travis CI configuration to run tests on PHP 7.2

AC:

main PHP version is 7.2
- except for functional tests, PHP version for which will be updated in a separate task
secondary PHP version is 7.1

Environment with PHP 7.2

Create a Docker box with PHP 7.2 for manual testing and development.

Host:

Mac
Linux
Win
xDebug

Broken integration test Magento\Catalog\Model\ResourceModel\Product\CollectionTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

19) Magento\Catalog\Model\ResourceModel\Product\CollectionTest::testJoinTable
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Collection/Interceptor.php:986
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Model/ResourceModel/Product/CollectionTest.php:140

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577321#L1396

Broken integration test Magento\Wishlist\Controller\IndexTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

10) Magento\Wishlist\Controller\IndexTest::testItemColumnBlock
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:320
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/Product/Compare/Item.php:207
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Observer/Compare/BindCustomerLogoutObserver.php:35
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/Session.php:467
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/Session/Interceptor.php:258
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Wishlist/Controller/IndexTest.php:52

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1202

magento/zf1 does not support PHP 7.2

Update https://github.com/magento/zf1, so it supports PHP 7.2.

review ZF1 library for incompatibilities with PHP 7.2

Repo: https://github.com/magento-engcom/zf1-php-7.2-support

Failing integration test Magento\Persistent\Block\Header\AdditionalTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

5) Magento\Persistent\Block\Header\AdditionalTest::testToHtml
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
-%A<span>%A<a%Ahref="http://localhost/index.php/persistent/index/unsetCookie/"%A>Not you?</a>%A</span>%A
+
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php:61

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1330

Failing unit test Magento\Framework\Api\Test\Unit\Code\Generator\GenerateMapperTest

Magento\Framework\Api\Test\Unit\Code\Generator\GenerateMapperTest::testGenerate
Failed asserting that false matches expected 'SampleMapper.php'.
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Api/Test/Unit/Code/Generator/GenerateMapperTest.php:56

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577316

Broken integration test Magento\Persistent\Model\ObserverTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

2) Magento\Persistent\Model\ObserverTest::testEmulateWelcomeBlock
Magento\Framework\Exception\NoSuchEntityException: No such entity with customerId = 
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Exception/NoSuchEntityException.php:49
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/CustomerRegistry.php:84
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/ResourceModel/CustomerRepository.php:288
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/ResourceModel/CustomerRepository/Interceptor.php:50
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Persistent/Model/Observer.php:90
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Persistent/Model/ObserverTest.php:110

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1111

Upgrade friendsofphp/php-cs-fixer

Upgrade friendsofphp/php-cs-fixer to the version that supports PHP 7.2. (Potentially ver. 2.10.0).

AC:

tests are green
usage scenarios are working

zendframework/zend-mail does not support PHP 7.2

zendframework/zend-mail#189

Broken integration test Magento\Persistent\Observer\EmulateQuoteObserverTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

4) Magento\Persistent\Observer\EmulateQuoteObserverTest::testEmulateQuote
Magento\Framework\Exception\NoSuchEntityException: No such entity with customerId = 
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Exception/NoSuchEntityException.php:49
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/CustomerRegistry.php:84
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/ResourceModel/CustomerRepository.php:288
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/ResourceModel/CustomerRepository/Interceptor.php:50
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Persistent/Observer/EmulateQuoteObserverTest.php:93

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1142

Warning: get_class() expects parameter 1 to be object, null given

Important: Use libs-upgrade branch as base for this task and as target for the PR.

Warning: get_class() expects parameter 1 to be object, null given on PHP 7.2

Broken integration test Magento\Catalog\Controller\Product\CompareTest

8) Magento\Catalog\Controller\Product\CompareTest::testAddAction
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:308
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:199
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:35
9) Magento\Catalog\Controller\Product\CompareTest::testIndexActionAddProducts
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:308
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:199
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:60
10) Magento\Catalog\Controller\Product\CompareTest::testRemoveAction
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:308
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:231
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:71
11) Magento\Catalog\Controller\Product\CompareTest::testRemoveActionWithSession
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:308
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:289
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:87
12) Magento\Catalog\Controller\Product\CompareTest::testIndexActionDisplay
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:308
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:231
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:104
13) Magento\Catalog\Controller\Product\CompareTest::testClearAction
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:308
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:231
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:130
14) Magento\Catalog\Controller\Product\CompareTest::testRemoveActionProductNameXss
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared/Collection/Interceptor.php:1051
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php:126
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php:140
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared/Collection/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/Product/Index/AbstractIndex.php:199
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Observer/CatalogProductCompareClearObserver.php:40
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Controller/Product/Compare/Remove.php:52
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Controller/Product/Compare/Remove/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/App/Action/Action.php:107
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:58
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:138
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:153
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Controller/Product/Compare/Remove/Interceptor.php:52
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/App/FrontController.php:55
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:58
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:138
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Store/App/FrontController/Plugin/RequestPreprocessor.php:94
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:135
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php:69
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:135
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Interception/Interceptor.php:153
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/App/FrontController/Interceptor.php:26
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/App/Http.php:135
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/App/Http/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/Magento/TestFramework/Application.php:449
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/Magento/TestFramework/Helper/Bootstrap.php:117
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/Magento/TestFramework/TestCase/AbstractController.php:100
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php:151

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577321#L1214

Failing unit test Magento\Framework\ObjectManager\Test\Unit\Code\Generator\GenerateRepositoryTest

50) Magento\Framework\ObjectManager\Test\Unit\Code\Generator\GenerateRepositoryTest::testGenerate with data set #0 ('Magento\Framework\ObjectManag...sitory', 'Magento\Framework\ObjectManag...Sample', 'SampleRepository')
Generated repository is invalid.
Failed asserting that false matches expected 'SampleRepository.php'.
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/ObjectManager/Test/Unit/Code/Generator/GenerateRepositoryTest.php:73
51) Magento\Framework\ObjectManager\Test\Unit\Code\Generator\GenerateRepositoryTest::testGenerate with data set #1 ('Magento\Framework\ObjectManag...sitory', 'Magento\Framework\ObjectManag...Sample', 'TSampleRepository')
Generated repository is invalid.
Failed asserting that false matches expected 'TSampleRepository.php'.
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/ObjectManager/Test/Unit/Code/Generator/GenerateRepositoryTest.php:73

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577316

\Magento\Framework\Data\OptionSourceInterface::toOptionArray() implementations are incompatible with the interface

Implementations of \Magento\Framework\Data\OptionSourceInterface::toOptionArray() are often incompatible with the interface and/or parent class, which causes fatal error in PHP 7.2.
Fix implementations so that interfaces are compatible.

Note: it's potentially backward incompatible change.

Failing integration test Magento\Persistent\Model\Checkout\GuestPaymentInformationManagementPluginTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

6) Magento\Persistent\Model\Checkout\GuestPaymentInformationManagementPluginTest::testBeforeSavePaymentInformationAndPlaceOrder
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'[email protected]'
+'[email protected]'
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Persistent/Model/Checkout/GuestPaymentInformationManagementPluginTest.php:237

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1340

Failing integration test Magento\ImportExport\Controller\Adminhtml\Import\ValidateTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

1) Magento\ImportExport\Controller\Adminhtml\Import\ValidateTest::testValidationReturn with data set #0 ('catalog_product.csv', 'File is valid', ',')
Failed asserting that '<script type='text/javascript'>\n
//<![CDATA[\n
    top.varienImport.postToFrameComplete({"clear":[],"innerHTML":{"import_validation_messages":"<div class=\"messages\"><div class=\"message message-error error\"><div data-ui-id=\"magento-framework-view-element-messages-0-message-error\" >Sorry, but the data is invalid or the file is not uploaded.<\/div><\/div><\/div>"},"value":[],"show":["import_validation_container"],"hide":[],"removeClassName":[],"addClassName":[]});\n
//]]>\n
</script>\n
' contains "File is valid".
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/ImportExport/Controller/Adminhtml/Import/ValidateTest.php:71
2) Magento\ImportExport\Controller\Adminhtml\Import\ValidateTest::testValidationReturn with data set #1 ('test.txt', ''txt' file extension is not supported', ',')
Failed asserting that '<script type='text/javascript'>\n
//<![CDATA[\n
    top.varienImport.postToFrameComplete({"clear":[],"innerHTML":{"import_validation_messages":"<div class=\"messages\"><div class=\"message message-error error\"><div data-ui-id=\"magento-framework-view-element-messages-0-message-error\" >Sorry, but the data is invalid or the file is not uploaded.<\/div><\/div><\/div>"},"value":[],"show":["import_validation_container"],"hide":[],"removeClassName":[],"addClassName":[]});\n
//]]>\n
</script>\n
' contains "'txt' file extension is not supported".
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/ImportExport/Controller/Adminhtml/Import/ValidateTest.php:71
3) Magento\ImportExport\Controller\Adminhtml\Import\ValidateTest::testValidationReturn with data set #2 ('incorrect_catalog_product_comma.csv', 'Download full report', ',')
Failed asserting that '<script type='text/javascript'>\n
//<![CDATA[\n
    top.varienImport.postToFrameComplete({"clear":[],"innerHTML":{"import_validation_messages":"<div class=\"messages\"><div class=\"message message-error error\"><div data-ui-id=\"magento-framework-view-element-messages-0-message-error\" >Sorry, but the data is invalid or the file is not uploaded.<\/div><\/div><\/div>"},"value":[],"show":["import_validation_container"],"hide":[],"removeClassName":[],"addClassName":[]});\n
//]]>\n
</script>\n
' contains "Download full report".
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/ImportExport/Controller/Adminhtml/Import/ValidateTest.php:71
4) Magento\ImportExport\Controller\Adminhtml\Import\ValidateTest::testValidationReturn with data set #3 ('incorrect_catalog_product_sem...on.csv', 'Download full report', ';')
Failed asserting that '<script type='text/javascript'>\n
//<![CDATA[\n
    top.varienImport.postToFrameComplete({"clear":[],"innerHTML":{"import_validation_messages":"<div class=\"messages\"><div class=\"message message-error error\"><div data-ui-id=\"magento-framework-view-element-messages-0-message-error\" >Sorry, but the data is invalid or the file is not uploaded.<\/div><\/div><\/div>"},"value":[],"show":["import_validation_container"],"hide":[],"removeClassName":[],"addClassName":[]});\n
//]]>\n
</script>\n
' contains "Download full report".
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/ImportExport/Controller/Adminhtml/Import/ValidateTest.php:71

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1290

Can't save product with Opcache enabled

When saving a simple product, one of the following errors occurs:

Warning: Narrowing occurred during type inference. Please file a bug report on bugs.php.net in /private/var/www/htdocs/m2-php72/magento2ce/vendor/composer/ClassLoader.php on line 412

Warning: Invalid argument supplied for foreach() in /private/var/www/htdocs/m2-php72/magento2ce/app/code/Magento/ConfigurableProduct/Model/Product/VariationHandler.php on line 243

Warning: count(): Parameter must be an array or an object that implements Countable

Important: Use libs-upgrade branch as base for this task and as target for the PR.

Warning on PHP 7.2: Warning: count(): Parameter must be an array or an object that implements Countable.
Usually, it's due to null being passed as an argument.
Also, usage of sizeof() should be fixed.

Usage of deprecated parameter $errcontext in error handlers

$errcontext parameter is deprecated in PHP 7.2.
Usages found in the following libraries:

magento/zendframework1
zendframework/zend-mail
zendframework/zend-soap
zendframework/zend-validator

Usage of deprecated $php_errormsg variable in libraries

$php_errormsg is deprecated in PHP 7.2. The following libraries rely on it:

magento/zendframework1
pdepend/pdepend
squizlabs/php_codesniffer

Broken static tests

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577318

The tests should be fixed in the scope of:

3rd-party libraries do not support PHP 7.2

List of Libraries to Update

zendframework/zend-mail - update to ver. 2.9.0. Issue #12
zend-soap - ver. 2.7.0 supports PHP 7.2. Issue #37 to validate usage of the new version.
~~pdepend/pdepend - uses deprecated $php_errormsg parameter~~ - used for PHP < 5.3
~~squizlabs/php_codesniffer - uses deprecated $php_errormsg parameter~~ - it's in the tests, not used in the executable
friendsofphp/php-cs-fixer - ver. 2.10.0 supports 7.2. Covered in #86
[done] pelago/emogrifier - ver. 2.0.0 supports 7.2. Issue #3 to validate.
[done] colinmollenhour/php-redis-session-abstract - ver. 1.3.8 supports PHP 7.2. Issue #1 to validate.
[done] sjparkinson/static-review - remove. #40
colinmollenhour/cache-backend-file - update tp ver. 1.4.1. Issue #88

Solution:

Create PRs to the libs that still have issues. Wait for them being merged and new version released. Depend on the new version.
Update dependencies to new versions that support PHP 7.2 (see versions mentioned in the list above)

Acceptance Criteria

composer update passes

In scope of this task, update composer.json and composer.lock, so that composer install passes. Any issues in the code to be reviewed and solved in related tasks for each library.

Use this branch for PRs - https://github.com/magento-engcom/php-7.2-support/tree/libs-upgrade

Related Issues

Failing unit test Magento\Framework\ObjectManager\Test\Unit\Code\Generator\FactoryTest

49) Magento\Framework\ObjectManager\Test\Unit\Code\Generator\FactoryTest::testGenerate
Failed asserting that false matches expected 'sample_file.php'.
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/ObjectManager/Test/Unit/Code/Generator/FactoryTest.php:61

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577316

mcrypt removed from PHP 7.2 core

Important: Use libs-upgrade branch as base for this task and as target for the PR.

Investigate possible solutions.

Options:

use sodium
use mcrypt_compat lib
require PECL installation of mcrypt
Other

Design document - https://github.com/magento-engcom/php-7.2-support/wiki/HLD---Removing-mcrypt-and-adding-libsodium

Broken functional tests

See functional tests job at https://travis-ci.org/magento-engcom/php-7.2-support , for branch workarounds

Failing unit test Magento\Setup\Test\Unit\Model\InstallerTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

53) Magento\Setup\Test\Unit\Model\InstallerTest::testCheckExtensionsError
Failed asserting that exception of type "\Exception" is thrown.

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577316

pelago/emogrifier does not support PHP 7.2

Update pelago/emogrifier (https://github.com/MyIntervals/emogrifier) to the version that supports PHP 7.2.

AC:

tests are green
usage scenarios are working

Ver. 2.0.0 supports 7.2

Remove sjparkinson/static-review

sjparkinson/static-review is abandoned.
Remove it from the dependencies list.
Remove dev/tools/Magento/Tools/StaticReview which depends on the library.

cc @piotrekkaminski

Usage of deprecated each() function

each() usages should be replaced with foreach.

Blocks installation.

friendsofphp/php-cs-fixer does not support PHP 7.2

Update friendsofphp/php-cs-fixer (https://github.com/FriendsOfPHP/PHP-CS-Fixer) to the version that supports PHP 7.2. Install latest version of friendsofphp/php-cs-fixer

AC:

tests are green
usage scenarios are working

It also requires update of symfony/console, symfony/process and symfony/event-dispatcher to a newer versions. Please update to the latest possible.

colinmollenhour/php-redis-session-abstract does not support PHP 7.2

Update https://github.com/colinmollenhour/php-redis-session-abstract so it supports PHP 7.2.

Ver. 1.3.8 supports PHP 7.2

AC:

tests are green
usage scenarios are working

Update zend-mail

Important: Use libs-upgrade branch as base for this task and as target for the PR.

Issues found in zend-mail:

INTL_IDNA_VARIANT_2003 is deprecated, and used as default value for idn_to_ascii() and idn_to_utf8(). See http://php.net/manual/en/migration72.deprecated.php for details.
\Zend\Mail\Header\AbstractAddressList::idnToAscii() uses idn_to_ascii() with the default value. Explicit value INTL_IDNA_VARIANT_UTS46 should be used as $variant. There is a PR to fix it - zendframework/zend-mail#189
Usage of deprecated $errcontext parameter - create PR to the zend-mail repo

A use case to test: create a customer from the store front. Currently it fails with:

Deprecated Functionality: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /private/var/www/htdocs/m2-php72/magento2ce/vendor/zendframework/zend-mail/src/Header/AbstractAddressList.php on line 105 {"exception":"[object] (Magento\\Framework\\Exception\\MailException(code: 0): Deprecated Functionality: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /private/var/www/htdocs/m2-php72/magento2ce/vendor/zendframework/zend-mail/src/Header/AbstractAddressList.php on line 105 at /private/var/www/htdocs/m2-php72/magento2ce/app/code/Magento/Email/Model/Transport.php:87, Exception(code: 0): Deprecated Functionality: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /private/var/www/htdocs/m2-php72/magento2ce/vendor/zendframework/zend-mail/src/Header/AbstractAddressList.php on line 105 at /private/var/www/htdocs/m2-php72/magento2ce/lib/internal/Magento/Framework/App/ErrorHandler.php:61)"} []

Solution: update to ver. 2.9.0

Broken integration test Magento\Wishlist\Controller\IndexTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

11) Magento\Wishlist\Controller\IndexTest::testAddActionProductNameXss
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:154
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:316
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/Product/Compare/Item.php:192
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Observer/Compare/BindCustomerLoginObserver.php:35
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/Session.php:435
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/Session/Interceptor.php:232
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Wishlist/Controller/IndexTest.php:41
12) Magento\Wishlist\Controller\IndexTest::testAllcartAction
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:320
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/Product/Compare/Item.php:207
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Observer/Compare/BindCustomerLogoutObserver.php:35
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/Session.php:467
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/Session/Interceptor.php:258
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Wishlist/Controller/IndexTest.php:52
13) Magento\Wishlist\Controller\IndexTest::testSendAction
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:167
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:37
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:320
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/Product/Compare/Item.php:207
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Observer/Compare/BindCustomerLogoutObserver.php:35
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/Session.php:467
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/Session/Interceptor.php:258
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Wishlist/Controller/IndexTest.php:52

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1223

Broken integration tests

See:

Some tests will be fixed in the scope of:

Broken integration test Magento\Persistent\Observer\EmulateCustomerObserverTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

3) Magento\Persistent\Observer\EmulateCustomerObserverTest::testEmulateCustomer
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:1116
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:226
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:89
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php:154
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Helper/Product/Compare.php:318
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Model/Product/Compare/Item.php:207
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Catalog/Observer/Compare/BindCustomerLogoutObserver.php:35
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Customer/Model/Session.php:467
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Customer/Model/Session/Interceptor.php:258
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Persistent/Observer/EmulateCustomerObserverTest.php:70

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1121

Broken integration test Magento\Backend\Block\Dashboard\Tab\Products\ViewedTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

3) Magento\Backend\Block\Dashboard\Tab\Products\ViewedTest::testGetPreparedCollectionProductPrice
PHPUnit\Framework\Exception: Notice: Undefined offset: 0 in /home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/framework/bootstrap.php:130
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php:816
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection/Interceptor.php:1051
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php:126
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php:140
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection/Interceptor.php:24
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Model/Product/Index/AbstractIndex.php:199
/home/travis/build/magento-engcom/php-7.2-support/app/code/Magento/Reports/Observer/CatalogProductViewObserver.php:79
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:72
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php:60
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Event/Manager.php:66
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/tmp/sandbox-0-c4b5b25471e569aacd36194c2bad027e/generated/code/Magento/Framework/Event/Manager/Proxy.php:95
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Backend/Block/Dashboard/Tab/Products/ViewedTest.php:58

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577321#L1023

Update zend-soap

Update zend-soap to the version that supports PHP 7.2 - ver. 2.7.0

Failing integration test Magento\Persistent\Observer\SynchronizePersistentOnLogoutObserverTest

Important: Use libs-upgrade branch as base for this task and as target for the PR.

7) Magento\Persistent\Observer\SynchronizePersistentOnLogoutObserverTest::testSynchronizePersistentOnLogout
Failed asserting that null matches expected 1.
/home/travis/build/magento-engcom/php-7.2-support/dev/tests/integration/testsuite/Magento/Persistent/Observer/SynchronizePersistentOnLogoutObserverTest.php:45

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577325#L1350

symfony/console does not support PHP 7.2

Update symfony/console so it supports PHP 7.2.
No version of symfony/console supports PHP 7.2 currently.

Also, latest version of friendsofphp/php-cs-fixer requires symfony/console ^3.2, while magento/composer requires ~2.3. We should update magento/composer to work with the latest symfony/console. See also #4

magento-engcom / php-7.2-support Goto Github PK

php-7.2-support's Introduction

Welcome

Magento system requirements

Install Magento

Contributing to the Magento 2 code base

Labels applied by the Magento team

Reporting security issues

License

php-7.2-support's People

Contributors

Stargazers

Watchers

Forkers

php-7.2-support's Issues

Steps to reproduce

Expected result

Actual result

List of Libraries to Update

Acceptance Criteria

Related Issues

Recommend Projects

Recommend Topics

Recommend Org