maccman / jquery.magicmove Goto Github PK

Hi! would love to use your package. What's the usage license?

Nice plugin, Alex. Can you add a link to the blog post and/or demo from the repo description and/or README file? I'm planning to feature this in my newsletter and I normally only include the direct link to the GH repo. I think it will help others sharing it, too. Thanks!

Swapping the positions of two elements works during the animation. Immediately afterwards, when the elements are unfixed, they return to their original position (because their DOM positions haven't changed).

In the library-provided demo, using the following callback in magicMove will replicate this issue.

        let $sections = $(this).find('section');
        let i = Math.floor(($sections.length - 1) * Math.random());
        $($sections[i]).insertAfter($sections[i + 1]);

Actually calculating the swap seems harder - perhaps making the following change in the .done() of the magicMove function could be the easiest solution? It works for the provided example and this swapping example, happy to log a pull request if you're happy with it.

    return promise.done(function () {
        // make the DOM a mirror of the cloned DOM
        $el.html($clone.html());
        // Remove 'absolute' styles
        $unfix.call($el.find(options.selector));
    });

Not sure if this is a bug or if the library is not supposed to cover this specific use case but when I remove an element, this is what happens:

1. All elements immediately jump back to the space available.
2. Next, magicMove seems to kick in and animates the elements forward.
3. Finally, the elements snap back to the correct position.

I'll make it clearer with this video.