m-renaud / cache Goto Github PK

The per-entry locking concurrency policy may have bugs in it's current state. It should be thoroughly tested for both correctness and efficiency, as well as be reviewed by some other programmers to ensure that there isn't anything that was missed.

Currently, PolymorphicCache does not use policy-based design. Once the Cache class has all of the bugs worked out, porting the polymorphic version should be relatively simple.

Currently, all the code lives in the same directory. Ideally, the policies should be separated in to appropriate sub-directories, and the cache code should live in an include/ directory.

To add a new entry to the cache, the member function should be insert(std::pair<key,value>), not create(key, value). I'm not entirely sure why I named it that in the first place.

Additionally, there is currently no find() function. The desired behaviour for this would be to return a shared_ptr to the object, with nullptr being returned if it doesn't exist in the cache or on disk, exactly the behaviour of operator[] currently. This also involves adding a typedef for an iterator that conforms to the standard containers.

Lastly, operator[] does not act like the associative containers. The options that I can think of now are either:

• Keep the behaviour as is (same as lookup()), which is not how it behaves in std::map
• Add a policy that dictates what should happen if the key does not exist (default construct a value?)
• Don't provide operator[]