Git Product home page Git Product logo

Comments (6)

lyz-code avatar lyz-code commented on June 24, 2024 2

Thank you to @superDross the feature is available under 1.0.0!!

I've decided to go with 1.0.0 because it looks like enough people is using it and the basic features are ready.

Thanks @Jasha10 @dbatten5 @JaapJoris @superDross @fsouza @HoverHell @jugmac00 @uuwaan for making it possible

from autoimport.

lyz-code avatar lyz-code commented on June 24, 2024 1

Hi @Jasha10, thanks for taking the time to open the issue, the behaviour described makes all the sense. Sadly, I won't be able to look into it this month as I'm a little bit overloaded.

If you can't wait and have coding skills and some time, feel free to make a pull request.

from autoimport.

lyz-code avatar lyz-code commented on June 24, 2024 1

autoimport accepts many files though, so if you're in a directory, you can do autoimport *.py. But it won't recursively search in the subdirectories, which would be ideal

from autoimport.

superDross avatar superDross commented on June 24, 2024

The above PR should facilitate the requested behavior.

I am struggling with getting this to work with mypy. Specifically the below error:

src/autoimport/entrypoints/cli.py:38: error: Incompatible return value type (got "Tuple[Any, ...]", expected "Tuple[Any]")  [return-value]
Found 1 error in 1 file (checked 6 source files)

I have been trying to resolve this for over an hour and cannot proceed with altering the types to get it to work. Any help would be appreciated.

The tests and linters are passing (at least locally) so this is the last issue before it will completely pass the pipeline.

from autoimport.

lyz-code avatar lyz-code commented on June 24, 2024

Sorry @superDross I didn't see this comment before answering to the PR, as I see from this stack overflow question the ellipsis is used in this case for :

Arbitrary-length homogeneous tuples can be expressed using one type and ellipsis, for example Tuple[int, ...]

What I understand from that is that as we don't know the number of arguments of the tuple, that is the correct function signature. you'll probably need to change it downstream too

from autoimport.

superDross avatar superDross commented on June 24, 2024

I have updated the PR and it is now passing the pipeline.

from autoimport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.