crashes when processing some imports that have `# comments` about autoimport HOT 7 CLOSED

Hey @Jasha10 sorry for the delay these days answering you, I didn't have much time. As always, thank you for your time opening issues and proposing fixes

from autoimport.

I'd vote to remove them. If someone complains in the future about this behaviour, we can always add a configuration option to prevent them to be removed. What did you have in mind?

from autoimport.

Hey @Jasha10 , I've been working on this issue.

The original issue was the use of noqa. autoimport only ignores the lines that have noqa: autoimport, so the next snippet works:

    source = dedent(
        """\
        # tmp.py
        from typing import Any  # noqa: autoimport
        from typing import TypeVar
        """
    )
    desired_source = dedent(
        """\
        # tmp.py

        from typing import Any  # noqa: autoimport
        """
    )

I think it's interesting to specify what kind of noqa you want to use, is very cumbersome for you to write the : autoimport?

I've also fixed the removal of the comment on simple import statements, on multiline will still fail, but I'm not sure it's a common case. If it is, whenever it occurs we can open another issue.

It should work on 0.9.0, if it doesn't please reopen the issue

from autoimport.

I'll try to submit a PR to fix this some time later this week.

from autoimport.

My pleasure! It turns out the bug was with comments in general, not with the word 'noqa' specifically.

What's the desired behavior for lines that have comments?
For example: I was able to get the following test case working by modifying autoimport's regex patterns:

    source = dedent(
        """\
        import os  # comment 1
        import sys  # comment 2

        os.getcwd()
        """
    )
    desired_source = dedent(
        """\
        import os  # comment 1
        # comment 2

        os.getcwd()
        """
    )

BUT, I'm not sure if preserving comment2 like that is desirable. For example, the user might have made a comment about the import, and now the comment makes no sense since the import is gone.

@lyz-code, what do you think is the best behavior for comments on imports that would be removed?

from autoimport.

Removing them sounds good to me! I didn't have anything in mind -- I couldn't think of a good solution xD

from autoimport.

Awesome, thanks for taking on the implementation :)

from autoimport.