- ๐ Hi, Iโm @lyjia
photog-screener's Introduction
photog-screener's People
photog-screener's Issues
Last image in scanned folder does not appear in image list
Describe the bug
All folder scans will omit the last image, but only when PhotogScreener is run without a debugger attached(?!).
To Reproduce
- Scan any folder
- Observe the final image in that folder is missing
- Observe the following log message
ERROR:root:I got back a QStandardItem instead of ScannedImage! WTF mate??? Skipping!
Expected behavior
The final image in a scanned folder should be present and analyzed like the others
Screenshots
n/a
Desktop (please complete the following information):
- OS: Windows 10
Additional context
- Problem only manifests when run without debugger (whatever debugger IDEA uses) is not attached. (Clicking the Play icon vs the Bug icon)
- Problem is easy to isolate by scanning a folder with only one image
MainWindow
movesRecursiveDirectoryScanner
to a new thread and executes it. As they are scanned,RecursiveDirectoryScanner
emits thefile_scanned
event, which requires an instance ofScannedImage
in its method signature. When this bug occurs, the instance ofScannedImage
that is expected is instead an instance of its superclass,QStandardItem
. If not handled, this crashes MainWindow and leaves the program in a broken state.
Image thumbnails corrupted
Describe the bug
Thumbnails for images that are not aspect ratio of 1:1 are corrupted when viewing in the image list
To Reproduce
Steps to reproduce the behavior:
- Scan any folder with images not 1:1 aspect ratio
- Observe thumbnails in results
Expected behavior
Thumbnails should not be corrupted
Desktop (please complete the following information):
n/a
Program sometimes crashes spontaneously or on running a second scan
Describe the bug
The program freezes for a few seconds and then crashes when the user requests to scan a folder a 2nd time. The program will exit with a strange random error code (Process finished with exit code -1073740791 (0xC0000409)
)
To Reproduce
Steps to reproduce the behavior:
- Scan any folder
- Scan a different folder
- Observe crash
Expected behavior
The program should not crash and the scan should complete.
Desktop (please complete the following information):
- OS: Windows 10
Additional context
- Does not occur 100% of the time, it is possible to run many scans without encountering a crash.
- Also observed the program crashing spontaenously, but only after a scan
- Suspect the problem has something to do with threading, am I not closing the scan thread correctly?
Raw camera image support
Describe the solution you'd like
Add support for reading raw camera images (NEF, etc) to PhotogScreener
Additional context
The plan is to use a python LibRaw library (rawpy?) to get the pixel data for the PhotogScreener's analysis functions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.