lyjia / photog-screener Goto Github PK

Describe the bug
All folder scans will omit the last image, but only when PhotogScreener is run without a debugger attached(?!).

To Reproduce

1. Scan any folder
2. Observe the final image in that folder is missing
3. Observe the following log message
   ERROR:root:I got back a QStandardItem instead of ScannedImage! WTF mate??? Skipping!

Expected behavior
The final image in a scanned folder should be present and analyzed like the others

Screenshots
n/a

Desktop (please complete the following information):

• OS: Windows 10

Additional context

• Problem only manifests when run without debugger (whatever debugger IDEA uses) is not attached. (Clicking the Play icon vs the Bug icon)
• Problem is easy to isolate by scanning a folder with only one image
• MainWindow moves RecursiveDirectoryScanner to a new thread and executes it. As they are scanned, RecursiveDirectoryScanner emits the file_scanned event, which requires an instance of ScannedImage in its method signature. When this bug occurs, the instance of ScannedImage that is expected is instead an instance of its superclass, QStandardItem. If not handled, this crashes MainWindow and leaves the program in a broken state.

Describe the bug
Thumbnails for images that are not aspect ratio of 1:1 are corrupted when viewing in the image list

To Reproduce
Steps to reproduce the behavior:

1. Scan any folder with images not 1:1 aspect ratio
2. Observe thumbnails in results

Expected behavior
Thumbnails should not be corrupted

Screenshots

Desktop (please complete the following information):
n/a

Describe the bug
The program freezes for a few seconds and then crashes when the user requests to scan a folder a 2nd time. The program will exit with a strange random error code (Process finished with exit code -1073740791 (0xC0000409))

To Reproduce
Steps to reproduce the behavior:

1. Scan any folder
2. Scan a different folder
3. Observe crash

Expected behavior
The program should not crash and the scan should complete.

Desktop (please complete the following information):

• OS: Windows 10

Additional context

• Does not occur 100% of the time, it is possible to run many scans without encountering a crash.
• Also observed the program crashing spontaenously, but only after a scan
• Suspect the problem has something to do with threading, am I not closing the scan thread correctly?

Describe the solution you'd like
Add support for reading raw camera images (NEF, etc) to PhotogScreener

Additional context
The plan is to use a python LibRaw library (rawpy?) to get the pixel data for the PhotogScreener's analysis functions