Git Product home page Git Product logo

Comments (5)

lyfeyaj avatar lyfeyaj commented on July 22, 2024

In case for some custom DOM change during resize, those setup operations are still needed to be executed to make sure the slide perform well.

[email protected] is released: fix duplicative event handlers when calling setup

from swipe.

sebworks avatar sebworks commented on July 22, 2024

@lyfeyaj, should the code be throttling onResize, as mentioned here: https://developer.mozilla.org/en-US/docs/Web/Events/resize?

from swipe.

sebworks avatar sebworks commented on July 22, 2024

I guess I'm struggling to see how this can possibly be performant. You are essentially detaching / reattaching event handlers every time a user resizes the browser ( potentially 100s of times ) . Why detach and then reattach? Seems unnecessary.

from swipe.

lyfeyaj avatar lyfeyaj commented on July 22, 2024

@sebworks Yes, we can use throttle to optimize the code, will add it later

from swipe.

lyfeyaj avatar lyfeyaj commented on July 22, 2024

throttled setup added in [email protected]

from swipe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.