Git Product home page Git Product logo

pe's People

Contributors

lwlshawn avatar

Watchers

 avatar

pe's Issues

Serious error in documentation of delete command

image.png

The documentation for delete states that it will only delete the corresponding elderly's next visit, but for elderly with recurring visits, it will delete ALL the visits and not just the "next visit". I felt that there was a significant difference between the two, hence the high severity.

Inaccurate documentation of Find command

image.png

Find command is stated to only display elderly whose name contain any of the given keywords above, but below in the blue box, the documentation suggests that the command searches other fields, like language

Lack of input validation

image.png

Despite being documented, perhaps this second listed behavior where sort v/lv/ becomes sort v/ should be avoided altogether? When this occurs in use, I think its most likely due to a user error, and should probably be flagged for their notice. I think its very unlikely that the user keys two prefixes v/lv/ and intended for only v/ to be interpreted.

Incorrect warning message regarding edit

image.png

When using edit to remove the lastvisit field, the application warns the user that a lastvisit date should be in the future. This happens when editing an elderly whose current visit date is wrong. Perhaps the warning should be kept to what happened in the current command?

I thought this might throw a user off slightly, as you are unable to edit the next visit field using the edit command, and are receiving an error unrelated to the command you have just executed.

To reproduce this, create an elderly with a lastvisit date, and a next visit date that is in the past, and use the command "edit INDEX lv/" to clear the last visit date

Inconsistent warnings with lastdate and futuredate errors

image.png

When a last visit date is in the future, the user gets a warning but there is no other indication on the application box. However, when a future visit is in the past, the date is highlighted in red, and the contact box for the user is in red as well.

Language allows any string

Although this is explicitly stated in the UG, perhaps restricting it to alphanumeric, or even strictly only alphabets might be better, given the form we expect a language to come in.

image.png

Incorrect error message

image.png

The application appears to recognise the wrong error here. I gave the wrong label for next visit (nv/) but the correct date, and receive a warning about the format of the date, instead of a notice that I have given the wrong command.

Possibly insufficient documentation of download command

image.png

I felt that reading this alone, it was not clear exactly what executing this command will do. For instance, what the format of the saved data will be, and what exactly will be contained. It is also unclear what the user should expect when executing the command (does the download happen immediately, will the user get to choose the location, etc.)

Phone number field might be too restrictive

image.png

The phone number field has a hard cap of 8 digits, disallowing local codes. This prevents the user from keying in any non-singaporean phone numbers. The user guide does not seem to make explicit that the application is meant for use only in Singapore, so perhaps this can be outlined in the documentation, or otherwise made more lenient.

Lack of documentation for duplicate detection

image.png

Two contacts with the same name are considered duplicates, but this does not appear to be mentioned in the User Guide. Given that it is possible for two different people to have the exact same name, perhaps a note should be added that this was intentional behavior? Either that or perhaps updating the way in which duplicates are detected. The given example above shows an attempt to add a new person with the same name, with entirely different fields

Possibly insufficient documentation for summary command

image.png

Perhaps more detail can be provided in the documentation, rather then simply stating "statistics", to help the user know what to expect. For example, the fact that the summary shows the total number of elderly is not reflected in the documentation.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.