lunchclass / absolute Goto Github PK

We are not sure that our project is working well in 32bit systems such as win 32bit, linux 32bit.
How can we test them? (Especially, windows?)

There are many problems when starting/stopping DB server.
In hackathon branch, we fixed them in workaround but it's not a good way.
We should rewrite the starting and stopping commands correctly.

For example, in server.js

const express = require('express');
const path = require('path');
const bodyParser = require('body-parser');
....

We should change the above codes as follows:
import express from 'express';
import path from 'path';
import body_parser from 'body-parser';

I'm not sure but there are some unnecessary files in the third_party/win-bash. (e.g. window.cmd?)
I don't know why it includes the unnecessary files but we should anyway remove them.

There is no 'wget' command on Mac OS.
We can consider 'curl' command instead of 'wget' on Mac.

Schedule 이나 timer 는 Orders 메뉴에서 임시로 일괄 Push / Schedule Push 를 넣으면 될것으로 생각함

Especially, we should run 'lint' command whenever developer commits his/her patch locally.
But how can we provide them smoothly? The git hook files should be located in .git/hooks/ but it's an untracked path. So, we probably should provide them in our repo and then copy them into the git hook directory when developer runs 'absolute' command at first.

Introduced run.cmd script to isolate Windows and POSIX in decf6c5

From now, we should finish to implement posix.sh to support Linux and Mac platform.
The script should be written as per bash scripting guide.

Note that the script need to distinguish Linux x86, Linux x64, and Darwin by default.

File upload library: multer

• it is express middleware.
• it support to sending multipart/form-data format.

File resizing library: graphicsmagick

• it support to make thumbnail, image resizing, blur, etc

Here it is sample source code.
http://webframeworks.kr/tutorials/expressjs/expressjs_file_upload/

server architecture
http://engineering.vcnc.co.kr/2016/05/ondemand-image-resizing/

Currently, we includes NodeJS binary(windows version) but it's not a good way because it increases the repo capacity. Therefore, we should implement NodeJS Downloader(and Updater) using shell script with wget.

When install npm package, npm binary file is in /server/ folder to window os.

I guess npm path refer global bin directory like below.

nodejs/.../gently-rm-linked-modules.js

  var globalBin = resolve(linkedGlobal, isWindows ? '.' : 'bin', 'linked')
  // on window os, use path '.' this is concept for nodejs.

  var globalModule = resolve(linkedGlobal, isWindows ? '.' : 'lib', 'node_modules', '@test', 'linked')
  var localBin = resolve(workingDir, 'node_modules', '.bin', 'linked')
  var localModule = resolve(workingDir, 'node_modules', '@test', 'linked')

nodejs/.../build.js

// if it's global, and folder is in {prefix}/node_modules,
// then bins are in {prefix}/bin
// otherwise, then bins are in folder/../.bin
var parent = pkg.name && pkg.name[0] === '@' ? path.dirname(path.dirname(folder)) : path.dirname(folder)
var gnm = global && npm.globalDir
var gtop = parent === gnm

function linkBins (pkg, folder, parent, gtop, cb) {
console.log("TWHY : linkBins parent=" + parent + ", gtop=" + gtop); //<--- gtop is true;
if (!pkg.bin || !gtop && path.basename(parent) !== 'node_modules') {
return cb()
}
var binRoot = gtop ? npm.globalBin //<--- use globanBin path.
: path.resolve(parent, '.bin')

I don't know why 'gtop' value is true. need more survey.

User Interface Flow

The temporary directory is not deleted in windows.

To avoid confusing situation, it's better to restrict using the 'require' function. Let's add a new lint rule for it and then only use |import| instead of |require|.

If we include them, where do we put them to?
If not, what is our fallback method? (e.g. download via script)

We want to use transpiler such as Babel, Google Traceur.

We need to investigate the database solution for our project. We should use a database that is cross-platform oriented, requires no installation, is distributed, and uses a socket.

The most database solution that works with node.js is implemented as a back-end that operates separately and provides a driver that can bind in node.js.

The following database solutions were investigated.

• Noms : This is the most ideal database, but it does not support the window environment. (There is no plan in the future.)
• MongoDB : Express is the most used database, but window needs to be installed.
• Levelup : No need to install, but access to file directly without using socket.
• Cassandra : By default, it does not support window environment. If you use DataSax, you can use it on Windows. But window needs to be installed.

In addition, express and frequently used solutions are as follows.

• Couchbase
• CouchDB
• MySQL
• Neo4j
• PostgreSQL
• Redis
• SQL Server
• SQLite
• ElasticSearch

To write safer code, we should consider to introduce test automation ways.

• How can we test platform dependent codes?
  • Do we need test servers?
• How can we test server side codes?
  • There might be Node JS modules for unit test.
• How can we test client side codes?
  • Do we need to consider cross-browsing?

Travis is working for this project but it does not support the windows-os.

This project should support windows environment also.

So additional ci-service should be made for windows-os

Currently, there is no public style guide in our project.
We just mentioned following the Google coding style guide but is it a best way?

Here are some coding style guide examples (including translated version):

• Google: https://google.github.io/styleguide/jsguide.html
• AirBnB: https://github.com/tipjs/javascript-style-guide
• Idiomatic.js: https://github.com/rwaldron/idiomatic.js/

In the current implementation, the npm will run to install packages whenever starting absolute.
But it's too inefficiency. We should fix it (introducing cache or another way..)

We need a commit description checker in travis bot. For example, we should check whether the each line of commit description is over than 80 bytes.

Server does not work when start in Window Git Bash.

1. The resone of that is pwd.exe can not support hangul.

Forever make debugging be difficult because target process always be restarting such as working normally even though there's fatal error.

• We have some options as follows:
  • nodemon

Once the bootstrap patch is landed(#73), we can try to remove them.

Currently, the commands are written by shell script but it's better to write by JS.

Introduced run.cmd script to isolate Windows and POSIX in decf6c5

From now, we should finish to implement windows.cmd to support Windows platform.
The script should be written as per batch scripting guide.

Note that the script need to distinguish 32bit, 64bit system by default.

@romandev requested.
Let's try to check codring style like Airbnb.
we'll discuss this issue with @gogag1 and start to solve this issue.

This is a meta bug to summarize TODO list in Absolute Hackathon.

forever's child process cannot find nodemon package.
I guess this problem is spawn's path issue by --prefix option of npm.

======================================

• Error logs.
  events.js:160
  throw er; // Unhandled 'error' event
  ^

Error: spawn nodemon ENOENT
at exports._errnoException (util.js:1022:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:359:16)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)

There are some solutions here, but they have not been verified.

• Docker
• NVM
• nodeenv (like virtualenv for Python)

We have to investigate above list and more things as follows:

• Can it support all platforms (at least Linux, Mac, Windows)?
• Whether it requires additional installation.
• Can it independent between Node modules and platforms?

• need to support Samsung Browser and Chrome(currenltly only Chrome works normally)
• need to support re-Request api for push

We are checking nodejs and mongodb directory.
If there is no folder, we will download each one.

But if it failed when we are downloading, we get directory, but file is not enough to run.
So we need to check downloading file integrity.

Below log is when downloading failed.
KOs-iMac:absolute kobyoungkwon$ ./run.cmd
./scripts/run: line 25: platform: command not found
./scripts/run: line 14: platform: command not found
./scripts/run: line 18: /Users/kobyoungkwon/romandev/absolute/platform/nodejs/bin/npm: No such file or directory
./scripts/run: line 19: /Users/kobyoungkwon/romandev/absolute/platform/nodejs/bin/npm: No such file or directory

1. Choose UI framework
2. Prototyping
3. Design component or make it out for Hackathon

Currently, node_modules are installed/updated whenever users run |absolute start| command.
But it's too inefficiency. Moreover, we don't need to install them again. (updating is enough).
So, we should make it update when only package.json is changed.

Once we finish to implement NodeJS Downloader via script(#19), we should remove NodeJS for Windows binaries from our repo.

Permission of absolute.cmd has been changed

-rw-r--r-- 1 sunemo83 staff 277 3 1 02:58 absolute.cmd

We use mongodb database solution for our project.
And we should define options for mongodb like logPath and dbPath.. and so on.

So, We need talk about path and make config file.

We have three issues.

1. where is dbPath?
2. where is logPath?
3. what is better between 2 case.
   1. 'make config file and commit to absolute repo'
   2. 'make config file when run script.' <-- I expect.

let's talk about this!

It need design json scheme for use nosql mongodb.

1. ordering list
2. menu items
3. session key

There's two issue

1st: Permission denied

Hyung-ui-iMac:absolute sunemo83$ ./absolute start
/Users/sunemo83/my_git/romandev/absolute/bootstrap/command/start_db: line 10: /Users/sunemo83/my_git/romandev/absolute/bootstrap/command/stop_db: Permission denied
warn: --minUptime not set. Defaulting to: 1000ms
warn: --spinSleepTime not set. Your script will exit if it does not stay up for at least 1000ms
info: Forever processing file: ./database.js
/Users/sunemo83/my_git/romandev/absolute/bootstrap/command/start_server: line 10: /Users/sunemo83/my_git/romandev/absolute/bootstrap/command/stop_server: Permission denied
warn: --minUptime not set. Defaulting to: 1000ms
warn: --spinSleepTime not set. Your script will exit if it does not stay up for at least 1000ms

2nd: Forever cannot find process with id: ./database.js

Hyung-ui-iMac:absolute sunemo83$ ./absolute start
error: Forever cannot find process with id: ./database.js
warn: --minUptime not set. Defaulting to: 1000ms
warn: --spinSleepTime not set. Your script will exit if it does not stay up for at least 1000ms
info: Forever processing file: ./database.js
error: Forever cannot find process with id: ./server.js
warn: --minUptime not set. Defaulting to: 1000ms
warn: --spinSleepTime not set. Your script will exit if it does not stay up for at least 1000ms
info: Forever processing file: ./server.js

Info of my environment
{
ProductName: Mac OS X
ProductVersion: 10.12.3
BuildVersion: 16D32
}

Issue version
{
commit b7a7d15
Author: Taeyun Kim [email protected]
Date: Wed Mar 1 00:09:44 2017 +0900

Apply mongodb script (#104)

}

• Here are some references:
  • https://blog.risingstack.com/node-hero-node-js-project-structure-tutorial/
  • http://stackoverflow.com/questions/5178334/folder-structure-for-a-node-js-project
  • https://gist.github.com/lancejpollard/1398757
  • https://www.terlici.com/2014/08/25/best-practices-express-structure.html

Sometimes, it can be useful to us. For example, some node_modules is removed in package.json.

Need to guide how to get certificate and generate csr to known CA and setup absolute project

It need session key for user verification. And It's stored to client's storage like cookie.

Sending picture

Query picture

Deleting picture (it needs to make a unique key for authority)

If we want to write codes for test, tools and so on using node js, we should consider to move the package.json to out of server directory.

There are two most popular view engine for nodejs.
jade : https://www.npmjs.com/package/jade

• not like html, it should be convert to jade from html
  ejs : http://ejs.co/
  i it can be also use html with tags

When sending the message via KakaoTalk, the link will be opened on internal WebView.
Then, we can not control service worker and related features.
So, we have to implement and use deep link to open the url to an external browser.