Hi, Drag and Drop does not work!
https://www.dropbox.com/s/soogh7h27wc2j91/2023-06-11%2001-57-07.mp4?dl=1

At least on Fedora Wayland it also needs these installed (tested it in Distrobox):

mesa-libgbm
libwayland-server

Hi,
I want to open a specific page from a PDF file in this app.

On Adobe Acrobat Reader/Pro, it's possible:

"%ProgramFiles%\Adobe\Acrobat DC\Acrobat\Acrobat.exe" /A "page=7" "C:\Program Files\Adobe\Acrobat DC\Acrobat\plug_ins\Annotations\Stamps\ENU\Standard.pdf"

Also all browser support this feature:
http://www.pdf995.com/samples/pdf.pdf#page=3.pdf

Please add this feature to this app.

Ability to return to a previous point in book if you randomly browse through the document outline, table of contents links or a random page input. This can be a multi step history like in browsers.

Hi, the file cannot be opened through OpenWith!
https://www.dropbox.com/s/soogh7h27wc2j91/2023-06-11%2001-57-07.mp4?dl=1

Thank you for supporting tab.
Please add keyboard shortcuts:

Thanks.

I didn't found any way to fix this. Would be great if you add theaming option.

Here are some small typos I noticed and the correct spelling to use:

It uses Electron but my eyes dont care. -> It uses Electron but my eyes don’t care.

• Tier 1: Linux, garunteed builds and garunteed 100% functionality -> - Tier 1: Linux, guaranteed builds and guaranteed 100% functionality

• Tier 2: Windows, garunteed builds. Functionality is not garunteed -> - Tier 2: Windows, guaranteed builds. Functionality is not guaranteed

• Tier 3: Macos, builds are not garunteed if it breaks fix is not garunteed. -> - Tier 3: Macos, builds are not guaranteed if it breaks fix is not guaranteed.

Hello! luv this app, can you guys please update the flathub version?..

Thank you!

Hi, Is this official?
https://flathub.org/apps/io.github.lunarequest.NightPDF

If yes, please add this to README.md

This app is providing all featues that we mostly use, but it would be more usefull if you can add few more features like -

1. Save Custom presents for backgrounds.
2. Context menus with features like copy, highlight, etc.
3. Meaning lookup.
4. Better theme support (Great if GTK4).
5. Eraser , Undo , Redo.

Thanks for beautiful app.

I love this PDF viewer, I feel that the only thing missing is the ability to open multiple books by tabs inside the program, since having several minimized program windows takes up too much space on my taskbar.

Thanks for your great work man. :)

I've found a large portion of issues related to updating electron and the such could have been fixed by using typescript. Going forward I will be moving towards using typescript in the project and rewriting all javascript to use typescript.

Please add donate info, like this:
https://github.com/mifi/lossless-cut

The program has one tab only. If clicking on the plus icon, it opens a new file and closes the old one.
There could be more tabs at the same time.

when nightpdf app is opened hotkeys like command + 1 , command + 2 dont work in other applications like chrome ,preview ..etc

just show 5 pdf tab

Where are the binaries for windows? What is the minimum NT 6.x version to run it?

Please use the dark scrollbar like Firefox.

NightPDF

Firefox

Thanks.

Hi, NightPDF open links.
Please disable the in-app browser.

you try , i am buzy

If you jump from the table of content in left side pane to a different place the page zoom gets reset to 100% (or Page Fit in some cases)

Please add these features to the program:

1. Reopening previous session (open all previous tabs)
2. Remember file viewing and settings.

Thanks.

Please add the feature below:

• Fit One Full Page
  
  In this mode, the whole page is displayed and it changes by scrolling the page.

It would be nice if there was a setting to enable where per-book settings and the page the user has left the book is remembered.

Please release this app to the Snap store.
https://snapcraft.io/docs/releasing-to-the-snap-store
Thanks.

Not particularly urgent but just wanted to bring it to your attention:

On macOS the sliders in the Custom menu are offset.

Genuinely a huge thank you for your work that's helping us save our eyes! 🙏🏾

Currently we use an inline version of PDF.js that is stored in app/libs/pdfjs by moving pdfjs outside the application instead shipping our own pdfjs version.

-- drawbacks
network access will always be required on first start up
on slow networks this could greatly increase download times.
this could also increase startup times on launch

-- possible mitigations
ship a cached pdfjs.zip(latest at time of build) and extract allowing the user to use nightpdf immediately.
produce a notification on a newer PDF.js and download only if the user requests
only check for new releases after launch asynchronously.

-- benfits
user always has the latest PDF.js version which often can include fixes and improvements
we can remove PDF.js from our direct source tree and move it elsewhere

Please add a button to view the original version of the documents. (light mode)

The reason I want to add this button is that some images may be negative:

编译报错

❯ yarn dist
yarn run v1.22.19
$ electron-builder
  • electron-builder  version=22.14.13 os=22.1.0
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=darwin arch=x64 electron=18.2.0 appOutDir=dist/mac
  • downloading     url=https://github.com/electron/electron/releases/download/v18.2.0/electron-v18.2.0-darwin-x64.zip size=82 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v18.2.0/electron-v18.2.0-darwin-x64.zip duration=22.517s
  • skipped macOS application code signing  reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible, see https://electron.build/code-signing allIdentities=     0 identities found
                                                Valid identities only
     0 valid identities found
  • building        target=macOS zip arch=x64 file=dist/NightPDF-0.4.1-mac.zip
  • building        target=DMG arch=x64 file=dist/NightPDF-0.4.1.dmg
  • building block map  blockMapFile=dist/NightPDF-0.4.1-mac.zip.blockmap
  ⨯ Exit code: ENOENT. spawn /usr/bin/python ENOENT  failedTask=build stackTrace=Error: Exit code: ENOENT. spawn /usr/bin/python ENOENT
    at /Applications/Opensource/NightPDF/node_modules/builder-util/src/util.ts:133:18
    at exithandler (node:child_process:410:5)
    at ChildProcess.errorhandler (node:child_process:422:5)
    at ChildProcess.emit (node:events:513:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
    at onErrorNT (node:internal/child_process:485:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

通过日志定位问题 Error: Exit code: ENOENT. spawn /usr/bin/python ENOENT

可能新的 macOS 内置 python 版本换到了 python3

安装 python2 尝试构建

踩坑后找到解决方案，节约时间踩坑过程就不列了
（比如 Poetry 不支持 python 2.7，在其项目 issue 讨论区得到结论确认）

❯ brew install kamilturek/python2/python@2 && brew install python@2
# find path by 
# brew info python@2
❯ export PYTHON_PATH=/usr/local/Cellar/python@2/2.7.18/bin/python

# build success
❯ yarn dist
yarn run v1.22.19
$ electron-builder
  • electron-builder  version=22.14.13 os=22.1.0
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=darwin arch=x64 electron=18.2.0 appOutDir=dist/mac
  • skipped macOS application code signing  reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible, see https://electron.build/code-signing allIdentities=     0 identities found
                                                Valid identities only
     0 valid identities found
  • building        target=macOS zip arch=x64 file=dist/NightPDF-0.4.1-mac.zip
  • building        target=DMG arch=x64 file=dist/NightPDF-0.4.1.dmg
  • building block map  blockMapFile=dist/NightPDF-0.4.1.dmg.blockmap
  • building block map  blockMapFile=dist/NightPDF-0.4.1-mac.zip.blockmap
✨  Done in 32.68s.

构建产物🔗

Notion Upload Link

NightPDF-0.4.1.dmg.blockmap

NightPDF-0.4.1.dmg

OSS Link

NightPDF-0.4.1.dmg

NightPDF-0.4.1.dmg.blockmap

Page Post on my blog

Hi, please capitalize the app name. (on Ubuntu Linux)

NightPdf -> NightPDF

Please add the "About" item to the Help menu.

Now I can't see the installed version.

This feature is on all apps for example VS Code.

currently we have to disable contextisolation for NightPDF to work, this is a massive security issue. we have to figure out why nightpdf breaks.

Hi, now the contents scrollbar is dark.
Please make the sidebar scrollbar dark.
Also please make thumbnails dark.

Thanks.

Hello,
Fedora silverblue v38. Installed NightPdf from flathub.
PDF files doesn't open with double-kick. I have to use the the file-menu->open dialog.
It seems like a bug.

thx

Please add a hotkey for the Escape key to close the app. (like Sumatra PDF)
Similar: #23

There is a small bug in the tabs titles.

The file name is "03. DevOps.pdf"

But in tab displayed: "DevOps.pdf .03"

I've made a website for nightpdf https://nightpdf.nullrequest.com and am looking for feedback on it anyone feel free to add your input here. The repo of the website is https://github.com/Lunarequest/nightpdf-website feel free to add pr's to make changes. it's my first time using astro or any javascript ui framework so I'm sure there are places it can be improved

and cyber theme like

look like this color ,like cyber punk ,
#c200e9
#07001d
#00ffff

Please support multi-file drag on Windows.

Now only open a file.
I expect open all files to separate tabs.

Please add feature below:

• Follow system theme by default
  
  Thanks.

Hi, please improve the app icon.
To do this, open the icon with the Greenfish Icon Editor Pro app on Linux or Windows.

1. As you can see, the icons are sorted in ascending order, that is, the smallest icon is at the top of the list and the largest icon is at the bottom of the list. This may seem trivial at first glance, but there is a bug in Windows that sometimes uses the first icon in the ICO file, regardless of the size of the icons, and this causes a small icon to be enlarged and finally, the poor-quality icon will be displayed.
   So the icons should be arranged in descending order.
   

2. A Windows icon should include the following sizes:
   256x256, 64x64, 48x48, 40x40, 32x32, 24x24, 20x20, and 16x16
   (All default Windows icons follow this rule)
   You have put sizes 192x192, 128x128, and 96x96 in your icon, which is useless, and you have not put sizes 16x16, 20x20, 24x24, 32x32, and 40x40, which are used in Windows.
   

Instead of creating an issue, I wanted to create a PR but I couldn't find the SVG icon (the mipmap should be created from a vector file, not just a resized picture)

(Sorry for my bad English)
Thanks. 🙏

Ubuntu 23.04 Software repository dowload

The sidebars do not match the chosen color scheme.

I did notice it missing that info when going to report another issue.

Likely not relevant right now since many will use flatpak, but it will be good for posterity if people can specify the version on "help" or when the software opens.

Either way, it is a great project, I cannot thank you enough.

I found this interesting software simple to be an alternative to Xodo Reader, however Windows identified the file as "suspicious" I know this is not true, I managed to install it, but unfortunately I can't open it, is there any solution for this?

And in case of doubt, I downloaded the file from here and not from anywhere else, but the first page I went to was this one here.

Hi,
I want to install the app for all users to %ProgramFiles% instead of %LocalAppData%
Like the Simplenote app: