luminousmen / grokking_concurrency Goto Github PK

In Librarian::run function, Librarian thread releases a writer lock and then immediately acquires a writer lock.
Other User threads can not acquire a writer lock in RWLock::acquire_read function. so... User threads result in starvation.
I think Librarian thread should release a writer lock before sleeping. :)

I noted a big fix 667d37e added the following snippet to method _on_accept of class Server:

Basically, the snippet re-register server_socket in the event loop every time a new connection is established with a client. As 667d37e said, the server cannot connect multiple clients without re-registration. In contrast, _on_read and _on_write handlers do not re-register sockets, but a client may send messages to the server multiple times.

What makes server_socket different so that we must re-register it to enble multiple connections to clients?