Git Product home page Git Product logo

wagtail-marketing-addons's People

Contributors

brammanuel avatar jjanssen avatar leewesleyv avatar tomdyson avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wagtail-marketing-addons's Issues

Enhance the docs

  • Getting started
  • Available settings
  • Score rationale
  • More about the what and why

Double old-path record will cause the import to throw a 500

In an occasion where an Excel list is handed over there is a possibility where a duplicate from-record exists. For example, having a file with over 1.000 records could have the following:

From To
/my/previous/location/1 /my/new/path
/my/previous/location/1 /my/new/some-other-path

When this is present the importer will throw an error as it tries to save another record in which old_path is classified unique:

duplicate key value violates unique constraint "wagtailredirects_redirect_old_path_site_id_783622d7_uniq"
DETAIL:  Key (old_path, site_id)=(/my/previous/location/1, 3) already exists.
mechanism

Proposed solution
We should wrap this in a try-catch, process the file accordingly and notify we have skipped a record due to a duplication.

Split-up SEO Listing and bulk redirect import into separate modules

Right now when initialising the marketing add-ons we validate if either the modeladmin and redirects is present within the current running application. Yet these are still features you can opt-in to when needed within Wagtail. Maybe the SEO listing is not relevant when you only want to use the bulk import but it will show-up in the navigation and it will require you to add the modeladmin to your INSTALLED_APPS.

Proposed solution

  • Place the modules in dedicated folders
  • Validate per installed module if the requirements are present
  • Take sub-dependency of a module into consideration

Score icons should give differentiable feedback

As of now, scores are displayed on a range of four emojis: 😏 😱 😢 😄

Without a legend or a title it is quite hard to see if the score is good or bad.

Possible solutions could be a change to a star-based (e.g. ⭐️-⭐️⭐️⭐️⭐️) or numerical (e.g. 0/10 - 10/10) rating

Create unit tests

  • Test edit-url resolving
  • Test score resolving
  • Test custom page model resolving
  • Quick test custom properties on view

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.