lukaspili / mortar-flow-dagger2-demo Goto Github PK

The way used to name scopes will create awfull issues (hard to understand/debug) :

You shouldn't use the class name for scopes like this :

@OverRide
public Context setUpContext(Path path, Context parentContext) {
MortarScope scope = screenScoper.getScreenScope(parentContext, path.getClass().getName(), path);
return new TearDownContext(parentContext, scope);
}

It took me 1 week to understand that this was causing all the problems I had in my app.
See there :
square/mortar#163

This is related to
square/mortar#149
And a fix was suggested upstream there :
square/mortar#161

Since Flow 1.0.0-alpha changed API significantly this great and helpful demo looks slightly outdated

Hi Lukas,

First of all, thanks for the outstanding job that you have been doing !
I have a question, I've checked out this example and I'm trying to login using FB login.
The problem is, inside my view I have a button callback that must call
'LoginManager.getInstance().logInWithReadPermissions(activity, permissions);'

How can I accomplish this ?
Thanks for your time !

This code looks very clean! Is there a way to start a subflow inside the main flow? For example, when detect there is permission issue, start a "login" flow to sign in/sign up. Also, is there any example/suggestion to integrate navigation draw and toolbar into this?