luizalabs / gandalf-lint Goto Github PK

lines-between-class-members

I think this rule was working on this project, but doesn't work anymore.
Could this be re-added (or added)?

"comma-dangle": [ "error", "always-multiline" ],

I'd like to have back this rule, because in git projects, it points a modification on a specific line, just because of the insertion of the comma.

I strongly recommend separating gandalf-lint in three projects:

• gandalf-lint-base: gandalf-lint for all JS projects independent of any framework;
• gandalf-lint-react: gandalf-lint-base + linting for react;
• gandalf-lint-vue: gandalf-lint-base + linting for vue;

Now that we have gandalf-lint-node I've been thinking in moving eslint-plugin-node from here to gandalf-lint-node.

What do you think?

Hi SofBoxLab team, this is a great code, thats for sharing.

Can you please clarify license for this repo? Hopefully MIT?

• "max-params": ["error", 3],
  Limita o máximo de parâmetros na função, forçando funções que tiverem mais parâmetros a serem tratadas como objects.

• Voltar com o "comma-dangle": [ "error", "always-multiline" ],

A regra abaixo está conflituando com o react-i18next.
Ele possui um HOC que injeta uma propriedade chamada t(). E com isso, a linha dá erro no id-length do eslint.

https://github.com/SoftboxLab/gandalf-lint/blob/26d391e89fc553fbbb0394b094a33058d353c583/rules/gandalf.js#L327

"max-params": ["error", 3],
Limits the maximum number of parameter of a function, forcing functions that have more than 3 parameters, to be treated as a json object.

some companies use this rule.

Airbnb: https://airbnb.io/javascript/#semicolons

Last ESLint updates changed some settings and now we have this warning related to Standard config:

(node:5933) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "node_modules/eslint-config-standard/index.js")

Maybe a dependencies update will solve it, community is already tracking this warning status:

standard/eslint-config-standard-react#48

No projeto Juggernaut nós sentimos a falta de uma documentação com as regras que são utilizadas no gandalf-lint, para decidirmos se ele realmente funcionaria para nós.

É possível criar uma documentação assim?

• Control Statements
• Comments
• Naming Conventions
• Accessors