I want to state before continuing that I am aware "Dynamic Music Updated" exists however, Dynamic Music Updated does not include 1.16 so this "legacy" version of Dynamic Music is the only way you can experience it on 1.16 which is why I opened this.

Anyways creative mode music and any track under a .creative tag, ie music.cold.creative, will play in survival meaning and creative mode (so non creative tagged music will never play) This effects every single version of "Dynamic Music" most importantly the forge 1.16 version. This is caused by a single line of code in a mixin file.

I also found another issue that makes night music not play after a Minecraft day has passed (will make a separate issue)

I do have a fix for both of these problems but I am awaiting some sort of response...

I did some testing on both a singleplayer world and a realm. The new soundtracks do NOT play in MP servers. Tested it with the lower pitched music that is supposed to play at midnight. It does not. I checked to make sure the mod is installed and it is. The only soundtracks that seem to play in MP are the creative mode soundtracks that play when in creative mode. I did read up that this mod IS clientside but overall does not work. Please fix this. 1.18.2.

1.18.2 made many large technical updates to the code and it made all mods incompatible. I try to play using this mod on 1.18.2 but it just crashes. could you update the mod so people who are playing on 1.18.2 can use it?

Hello there,

Here's a crash report : https://pastebin.com/QC9YghW9
Mod version : https://www.curseforge.com/minecraft/mc-mods/dynamic-music/files/3632323

If you need something, feel free to DM me on Discord -> Hangenbo#1933
It will be more faster.

Good idea to update the mod.

Game log

Tested with only Dynamic Music 1.3.1 and Fabric API 0.40.6+1.17 on Minecraft 1.17.1 with Fabric Loader 0.12.1

Can we add custom musics ourselves in some way ?
As an example, downloading an .OGG or .MP3 file and use it to play in cold biomes, or when below y60
Or does this already exist and i just didn't stumbled on it ?

crash-2022-05-27_14.45.43-client.txt
I've made sure there were no other mods, and I had fabric api installed.

Dynamic Music 1.3.1 prevents Disc 13 from playing in a Jukebox. Interestingly enough, the End dungeon plays this same track, and without issues.

There is crash report:
crash-2022-02-02_13.21.32-client.txt

Port for fabric 1.18.2

Hi, I do not want to bother, but I just wanted to say that my modpack dynamic music currently does not seem to play. Rather instead of just the default Minecraft music, have I missed something that I need to configure? Also, is it possible that one of the mods that I have installed could stop dynamic music from playing?

This mod triggers the "Incompatible FML Server" X mark on servers that do not have the mod running on the server despite it being a client side mod. This is confirmed in the log where, every time it pings the server before joining it says: [14:47:10] [Netty Client IO #11/INFO] [ne.mi.fm.cl.ClientHooks/CLIENTHOOKS]: Client has mods that are missing on server: [dynmus].

I can still join the server fine, just a little annoying is all.

V. 1.3.1

on Iris & Sodium for 1.18.1, only the main menu plays music from the mod, during gameplay (only tested singleplayer so far) only the default minecraft music is playing. Yes, I have Mod Menu installed and the mod is installed properly, and yes, I tried putting master volume to 0% and back up a lot of times, didn't help either unofortunately.
Affects both Mod Version 1.4.1 and 1.4.0

Incompatible with Atmosfera since both inject into getMusicType and don't respect each others choices

https://github.com/Haven-King/Atmosfera/blob/b85796ca1af1426af4a6534b51983dd6fd575998/src/main/java/dev/hephaestus/atmosfera/mixin/MinecraftClientMixin.java#L38

Whenever im in a different biome or time, no music plays. I already tried to solve the problem myself but i couldnt find anything. Never heard a music after i installed this mod.

https://paste.atlauncher.com/view/095f3277-4b94-42bf-bb85-095e0907731b

crash-2022-02-18_11.07.35-client.txt

Crashes on 1.18.2

https://crashy.net/ZltyON8QpexTuRewmiUX

---- Minecraft Crash Report ----
// You're mean.

Time: 5/21/22, 2:20 PM
Description: Unexpected error

java.lang.NoSuchMethodError: 'net.minecraft.class_1959 net.minecraft.class_4543.method_22393(net.minecraft.class_2338)'
at Not Enough Crashes deobfuscated stack trace.(1.18.2+build.3)
at net.minecraft.client.MinecraftClient.handler$zmn000$dynmus$getMusicType(MinecraftClient:7969)
at net.minecraft.client.MinecraftClient.getMusicType(MinecraftClient:2548)
at net.minecraft.client.sound.MusicTracker.tick(MusicTracker:27)
at net.minecraft.client.MinecraftClient.tick(MinecraftClient:1769)
at net.minecraft.client.MinecraftClient.render(MinecraftClient:1091)
at net.minecraft.client.MinecraftClient.run(MinecraftClient:737)
at net.minecraft.client.main.Main.main(Main:236)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:460)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at net.minecraft.class_310.handler$zmn000$dynmus$getMusicType(class_310.java:7969)
at net.minecraft.class_310.method_1544(class_310.java:2548)
at net.minecraft.class_1142.method_18669(class_1142.java:27)

-- Affected level --
Details:
All players: 1 total; [class_746['_Smoreo'/128, l='ClientLevel', x=1088.19, y=67.00, z=-319.30]]
Chunk stats: 16384, 360
Level dimension: minecraft:overworld
Level spawn location: World: (0,88,0), Section: (at 0,8,0 in 0,5,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
Level time: 39501 game time, 50136 day time
Server brand: fabric
Server type: Integrated singleplayer server
Stacktrace:
at net.minecraft.class_638.method_8538(class_638.java:407)
at net.minecraft.class_310.method_1587(class_310.java:2376)
at net.minecraft.class_310.method_1514(class_310.java:761)
at net.minecraft.client.main.Main.main(Main.java:236)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:460)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Last reload --
Details:
Reload number: 1
Reload reason: initial
Finished: Yes
Packs: Default, Fabric Mods, lambdabettergrass/default, continuity/default, continuity/glass_pane_culling_fix, Mod Menu Helper.zip, minecraft/supporteatinganimation, EmbellishedStone-1.18-1.0.0.zip, Ore_Variants_v2.3.zip, Stay_True_1.18.zip, illuminations/pixelaccurate

-- System Details --
Details:
Minecraft Version: 1.18.2
Minecraft Version ID: 1.18.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 17.0.1, Microsoft
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
Memory: 620458400 bytes (591 MiB) / 1845493760 bytes (1760 MiB) up to 4294967296 bytes (4096 MiB)
CPUs: 16
Processor Vendor: AuthenticAMD
Processor Name: AMD Ryzen 7 3700X 8-Core Processor
Identifier: AuthenticAMD Family 23 Model 113 Stepping 0
Microarchitecture: unknown
Frequency (GHz): 4.05
Number of physical packages: 1
Number of physical CPUs: 8
Number of logical CPUs: 16
Graphics card #0 name: NVIDIA GeForce GTX 1060 6GB
Graphics card #0 vendor: NVIDIA (0x10de)
Graphics card #0 VRAM (MB): 4095.00
Graphics card #0 deviceId: 0x1c03
Graphics card #0 versionInfo: DriverVersion=30.0.15.1277
Memory slot #0 capacity (MB): 8192.00
Memory slot #0 clockSpeed (GHz): 3.60
Memory slot #0 type: DDR4
Memory slot #1 capacity (MB): 8192.00
Memory slot #1 clockSpeed (GHz): 3.60
Memory slot #1 type: DDR4
Memory slot #2 capacity (MB): 8192.00
Memory slot #2 clockSpeed (GHz): 3.60
Memory slot #2 type: DDR4
Memory slot #3 capacity (MB): 8192.00
Memory slot #3 clockSpeed (GHz): 3.60
Memory slot #3 type: DDR4
Virtual memory max (MB): 37543.18
Virtual memory used (MB): 23848.64
Swap memory total (MB): 4864.00
Swap memory used (MB): 160.47
JVM Flags: 12 total; -XX:-OmitStackTraceInFastThrow -Xms512M -Xmx4096M -XX:MetaspaceSize=256M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M
Fabric Mods:
advanced_runtime_resource_pack: Runtime Resource Pack 0.5.5
advancementinfo: AdvancementInfo 1.18.2-fabric0.47.10-1.3.1
advancementplaques: Advancement Plaques 1.4.4
animatica: Animatica 0.4+1.18
antighost: AntiGhost 1.18.2-fabric0.47.10-1.1.4
appleskin: AppleSkin 2.4.0+mc1.18.2
architectury: Architectury 4.4.60
armorchroma: Armor Chroma 1.2.1
betteradvancements: Better Advancements 0.2.0.129
betterf3: BetterF3 1.2.5
bettermounthud: Better Mount HUD 1.1.4
betterthirdperson: Better Third Person 1.7.3
blur: Blur (Fabric) 2.4.1
borderlessmining: Borderless Mining 1.1.2+1.18.2
caffeineconfig: CaffeineConfig 1.1.0
capes: Capes 1.3.1+1.18.2
cardinal-components-base: Cardinal Components API (base) 4.1.4
cardinal-components-entity: Cardinal Components API (entities) 4.1.4
cem: Custom Entity Models 0.7.1
citresewn: CIT Resewn 1.0.1+1.18.2
citresewn-defaults: CIT Resewn: Defaults 1.0.1+1.18.2
clickadv: Clickable Advancements Mod 2.6
cloth-api: Cloth API 3.2.64
cloth-basic-math: cloth-basic-math 0.6.1
cloth-client-events-v0: Cloth Client Events v0 3.2.64
cloth-common-events-v1: Cloth Common Events v1 3.2.64
cloth-config: Cloth Config v6 6.2.62
cloth-datagen-api-v1: Cloth Datagen v1 3.2.64
cloth-scissors-api-v1: Cloth Scissors API v1 3.2.64
cloth-utils-v1: Cloth Utils v1 3.2.64
colormatic: Colormatic 3.1.1+mc.1.18.2
com_electronwill_night-config_core: core 3.6.3
com_electronwill_night-config_toml: toml 3.6.3
com_github_llamalad7_mixinextras: mixinextras 0.0.9
com_moandjiezana_toml_toml4j: toml4j 0.7.2
completeconfig: CompleteConfig 1.4.1
continuity: Continuity 1.1.0+1.18.2
controlling: Controlling For Fabric 9.0+19
crawl: Crawl 0.10.6
creativecore: CreativeCore (Fabric) 2.6.10
crowdin-translate: CrowdinTranslate 1.4+1.18.2
cull-less-leaves: Cull Less Leaves 1.0.0
dcch: DCCH 1.0
debugify: Debugify 1.10.0
dev_isxander_settxi: settxi 2.1.1
dynamicfps: Dynamic FPS 2.1.0
dynmus: Dynamic Music 1.4.1
easiervillagertrading: EasierVillagerTrading 1.18.2-fabric0.47.10-1.5.4
eatinganimationid: Eating Animation 1.6
effective: Effective 1.2.1
enhancedblockentities: Enhanced Block Entities 0.6+1.18.2
entity_texture_features: Entity Texture Features 2.6.0
entityculling: EntityCulling-Fabric 1.5.1
fabric: Fabric API 0.51.1+1.18.2
fabric-api-base: Fabric API Base 0.4.4+d7c144a860
fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.0+2373a54560
fabric-biome-api-v1: Fabric Biome API (v1) 8.0.4+7b0f312660
fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.12+3ac43d9560
fabric-command-api-v1: Fabric Command API (v1) 1.1.9+d7c144a860
fabric-commands-v0: Fabric Commands (v0) 0.2.8+b4f4f6cd60
fabric-containers-v0: Fabric Containers (v0) 0.1.21+d7c144a860
fabric-content-registries-v0: Fabric Content Registries (v0) 3.0.3+d82b939260
fabric-convention-tags-v1: Fabric Convention Tags 1.0.1+474e4f7960
fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.11+3ac43d9560
fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.17+2540745460
fabric-entity-events-v1: Fabric Entity Events (v1) 1.4.8+d7c144a860
fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.19+d7c144a860
fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.14+d7c144a860
fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.13+d7c144a860
fabric-item-api-v1: Fabric Item API (v1) 1.4.0+4457765560
fabric-item-groups-v0: Fabric Item Groups (v0) 0.3.11+91896a4960
fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.12+54e5b2ec60
fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.10+b4f4f6cd60
fabric-language-kotlin: Fabric Language Kotlin 1.7.4+kotlin.1.6.21
fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.0.3+2d83e92c60
fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.0.11+d7c144a860
fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.0+81ea5b3c60
fabric-models-v0: Fabric Models (v0) 0.3.6+d7c144a860
fabric-networking-api-v1: Fabric Networking API (v1) 1.0.21+d882b91560
fabric-networking-v0: Fabric Networking (v0) 0.3.8+b4f4f6cd60
fabric-object-builder-api-v1: Fabric Object Builder API (v1) 2.1.0+fe4ddef060
fabric-particles-v1: Fabric Particles (v1) 0.2.12+526dc1ac60
fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.9.8+0d9ab37260
fabric-renderer-api-v1: Fabric Renderer API (v1) 0.4.13+d882b91560
fabric-renderer-indigo: Fabric Renderer - Indigo 0.5.0+7faf0d8860
fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.11+b4f4f6cd60
fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.7+d7c144a860
fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 2.0.2+54e5b2ec60
fabric-rendering-v0: Fabric Rendering (v0) 1.1.13+b4f4f6cd60
fabric-rendering-v1: Fabric Rendering (v1) 1.10.7+54e5b2ec60
fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.0.3+91b7aa6660
fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.4.18+2de5574560
fabric-screen-api-v1: Fabric Screen API (v1) 1.0.10+d882b91560
fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.2.0+1f6558e860
fabric-textures-v0: Fabric Textures (v0) 1.0.12+3ac43d9560
fabric-transfer-api-v1: Fabric Transfer API (v1) 1.6.0+2373a54560
fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 1.0.0+bd8a4a1860
fabricloader: Fabric Loader 0.14.5
fabrishot: Fabrishot ${version}
fallingleaves: Falling Leaves 1.11.1+1.18.2
farsight: Farsight Mod 1.18-1.9
ferritecore: FerriteCore 4.2.1
forgeconfigapiport: Forge Config API Port 3.2.0
gbfabrictools: GBfabrictools 1.3.4+1.18.2
goosik-config: goosik-config 0.2.0
iceberg: Iceberg 1.0.38
illuminations: Illuminations 1.10.4
indium: Indium 1.0.3+mc1.18.2
iris: Iris 1.2.4-build.38
isxander-main-menu-credits: Main Menu Credits 1.0.2
itemmodelfix: Item Model Fix 1.0.3+1.18
java: OpenJDK 64-Bit Server VM 17
lambdabettergrass: LambdaBetterGrass 1.2.3+1.18
lambdynlights: LambDynamicLights 2.1.0+1.17
languagereload: Language Reload 1.2.1
lazydfu: LazyDFU 0.1.2
lithium: Lithium 0.7.9
malilib: MaLiLib 0.12.1
midnightlib: MidnightLib 0.4.0
minecraft: Minecraft 1.18.2
mm: Manningham Mills 2.3
modmenu: Mod Menu 3.2.2
morechathistory: MoreChatHistory 1.1.0
mousetweaks: Mouse Tweaks 2.22
nofade: No Fade 1.18-2.0.1
notenoughcrashes: Not Enough Crashes 4.1.6+1.18.2
omega-config: OmegaConfig 1.2.3-1.18.1
optigui: OptiGUI 1.0.4
org_anarres_jcpp: jcpp 1.4.14
org_apache_commons_commons-text: commons-text 1.9
org_bundleproject_libversion: libversion 0.0.3
org_jetbrains_kotlin_kotlin-reflect: kotlin-reflect 1.6.21
org_jetbrains_kotlin_kotlin-stdlib: kotlin-stdlib 1.6.21
org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 1.6.21
org_jetbrains_kotlin_kotlin-stdlib-jdk8: kotlin-stdlib-jdk8 1.6.21
org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm: kotlinx-coroutines-core-jvm 1.6.1
org_jetbrains_kotlinx_kotlinx-coroutines-jdk8: kotlinx-coroutines-jdk8 1.6.1
org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm: kotlinx-serialization-cbor-jvm 1.3.2
org_jetbrains_kotlinx_kotlinx-serialization-core-jvm: kotlinx-serialization-core-jvm 1.3.2
org_jetbrains_kotlinx_kotlinx-serialization-json-jvm: kotlinx-serialization-json-jvm 1.3.2
org_joml_joml: joml 1.10.2
physicsmod: Physics Mod 2.7.5
pickupnotifier: Pick Up Notifier 3.2.0
pride: Pride Lib 1.1.0+1.17
puzzle: Puzzle 1.2.1
puzzle-base: Puzzle Base 1.2.1
puzzle-gui: Puzzle GUI 1.2.1
puzzle-models: Puzzle Models 1.2.1
puzzle-splashscreen: Puzzle Splash Screen 1.2.1
puzzleslib: Puzzles Lib 3.3.1
reeses-sodium-options: Reese's Sodium Options 1.4.2
replanter: Replanter 1.3
satin: Satin 1.7.0
settxicloth: Settxi Cloth Impl 1.0.1
slotlock: SlotLock 1.0.4-BETA+1.18
smoothboot: Smooth Boot 1.18.2-1.7.0
smoothswapping: Smooth Swapping 0.4.4
sodium: Sodium 0.4.1+build.15
sodium-extra: Sodium Extra 0.4.3
spruceui: SpruceUI 3.3.3+1.18
starlight: Starlight 1.0.2+fabric.89b8d9f
tlcosmetica: Cosmetica 0.4.0
tooltipfix: ToolTip Fix 1.0.4-1.18
torohealth: ToroHealth Damage Indicators 1.18-fabric-2
tweakeroo: Tweakeroo 0.13.3
visuality: Visuality 0.4.2
xaerominimap: Xaero's Minimap 22.8.2
xaeroworldmap: Xaero's World Map 1.22.0
yosbr: YOSBR 0.1.1
zoomify: Zoomify 1.5.0
Loaded Shaderpack: Sildur's Default - Fancy.zip
Profile: Fancy (+0 options changed by user)
Launched Version: 1.18.2
Backend library: LWJGL version 3.2.2 build 10
Backend API: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 GL version 3.2.0 NVIDIA 512.77, NVIDIA Corporation
Window size: 2560x1440
GL Caps: Using framebuffer using OpenGL 3.2
GL debug messages:
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
Type: Integrated Server (map_client.txt)
Graphics mode: fancy
Resource Packs: vanilla, Fabric Mods, lambdabettergrass/default (incompatible), continuity/default, continuity/glass_pane_culling_fix, file/Mod Menu Helper.zip, minecraft/supporteatinganimation, file/EmbellishedStone-1.18-1.0.0.zip, file/Ore_Variants_v2.3.zip, file/Stay_True_1.18.zip, illuminations/pixelaccurate
Current Language: English (US)
CPU: 16x AMD Ryzen 7 3700X 8-Core Processor
Server Running: true
Player Count: 1 / 8; [class_3222['_Smoreo'/128, l='ServerLevel[New World]', x=1088.19, y=67.00, z=-319.30]]
Data Packs: vanilla, Fabric Mods
World Generation: Stable
Client Crashes Since Restart: 1
Integrated Server Crashes Since Restart: 0
Suspected Mods: None

WARN line

File dynmus:sounds/music/13_record_c418_death.ogg does not exist, cannot add it to event minecraft:music_disc.13