Git Product home page Git Product logo

atomic-plugins-ads's People

Contributors

bluesialia avatar mortimergoro avatar rogersolsona avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

atomic-plugins-ads's Issues

Rewarded Video triggers "success" even if canceled on iOS

This is the sample code from cocoon_ads.js

        /**
         * Triggered when an video reward is completed.
         * @memberOf Cocoon.Ad.Interstitial
         * @event On reward
         * @example
         * interstitial.on("reward", function(reward, error){
         *   if (reward && reward.amount > 0) {
         *     console.log("Reward completed. Earned " + reward.amount + " items");
         *   }
         * });
         */

On Android the error parameter is empty when the video has been fully watched, or it's a string when user canceled the video. This way we can check in code whether we should reward the user or not. And that is awesome.

The problem is that the same code on iOS works differently. The error parameter is empty no matter if the video was canceled or not. This means it's not possible to check whether we should reward a user or not.

Could you please take a look at the iOS code? It looks like some small issue... a typo possibly?

BTW: The reward parameter (tested on Android) is not an object and does not have the .amount member. It's simply a string so it is no use here.

Thanks

Ads not showing

Hello,
I'm currently trying to integrate mopub (android, ios) to my cordova game. I'm trying the code examples from the readme, unchanged (except ids). But for some reason the plugins are just not working. And the weirdest part is that there is no errors neither in javascript console nor emulator console. Is this a bug or am i doing something completely wrong?

Feature Request - Show multiple ads per screen

Is there a way we can show multiple ads per screen?

Example: So there is facebook like newsfeed, we show an advert at the top and then user scrolls down and we show another advert. Ads are far apart this way so only 1 ad is viewable at a time.

how to use this with plain CORDOVA?

i was trying to use this plugin with (CORDOVA without cocoon) as Cocoon is based on Cordova and if this is working in cocoon than it should work on cordova also, but when i tried it failed with error something like

"cocoon not defined"

"itemKey" causes App Store Reject

Apple says,

Your app uses or references the following non-public APIs:

itemKey

The use of non-public APIs is not permitted on the App Store because it can lead to a poor user experience should these APIs change.

Next Steps

Please revise your app to remove any non-public APIs. If you have defined methods in your source code with the same names as the above-mentioned APIs, we suggest altering your method names so that they no longer collide with Apple's private APIs to avoid your application being flagged in future submissions.

For a example, it' in the LDAdServiceChartboost.h.

@Property (nonatomic, strong) NSString *itemKey;

One thing is strange that I use this API in my oldest version APPs, but threre're no rejects with this issue.
I told Apple wondering why.

Apple replies,

We have begun asking that all developers update their apps to remove private API’s.
We appreciate your cooperation with these matters.

Plugin Causing Compilation Problems

Hi. Apparently, this plugin is causing Cordova apps not to compile successfully. This is the error message I keep getting, similar to Cranberrygame's equivalent plugin:

COMPILER ERROR:

/workspace/platforms/android/gradlew: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

  • What went wrong:
    A problem occurred configuring root project 'android'.

Could not resolve all dependencies for configuration ':_armv7DebugApkCopy'.
Could not find com.google.android.gms:play-services-ads:15.0.1.
Searched in the following locations:
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
Required by:
project :

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

CORDOVA LOG:

/workspace/plugins/cordova-plugin-filepath/CHANGELOG.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/LICENSE.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/README.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/package.json
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/plugin.xml

skipping existing file: FilePath.java
skipping existing file: FilePath.js
�[36m20181121T135342 [DEBUG] AndroidBuilder -�[39m [build]
Warning: File /.android/repositories.cfg could not be loaded.
�[36m20181121T135344 [DEBUG] AndroidBuilder -�[39m [build] create certs folder
�[36m20181121T135344 [DEBUG] AndroidBuilder -�[39m [build] keystore
�[36m20181121T135344 [DEBUG] AndroidBuilder -�[39m [build] create build.json
�[36m20181121T135344 [DEBUG] AndroidBuilder -�[39m [build] call cordova
cp: dest file already exists: /workspace/plugins/cocoon-plugin-android-architecture/LICENSE

cp: dest file already exists: /workspace/plugins/cocoon-plugin-android-architecture/LICENSE
cp: dest file already exists: /workspace/plugins/cocoon-plugin-android-architecture/README.md

skipping existing file: architecture.gradle
cp: dest file already exists: /workspace/plugins/cocoon-plugin-android-architecture/LICENSE
cp: dest file already exists: /workspace/plugins/cocoon-plugin-android-architecture/README.md
cp: dest file already exists: /workspace/plugins/cocoon-plugin-android-architecture/plugin.xml

cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/CHANGELOG.md

cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/CHANGELOG.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/LICENSE.md

cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/CHANGELOG.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/LICENSE.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/README.md

cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/CHANGELOG.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/LICENSE.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/README.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/package.json

cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/CHANGELOG.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/LICENSE.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/README.md
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/package.json
cp: dest file already exists: /workspace/plugins/cordova-plugin-filepath/plugin.xml

skipping existing file: FilePath.java
skipping existing file: FilePath.js
ANDROID_HOME=/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux
JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
Subproject Path: CordovaLib
The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
at build_2r6c57ziz211y74otld4kkop.run(/workspace/platforms/android/build.gradle:139)
The JavaCompile.setDependencyCacheDir() method has been deprecated and is scheduled to be removed in Gradle 4.0.
Incremental java compilation is an incubating feature.
The TaskInputs.source(Object) method has been deprecated and is scheduled to be removed in Gradle 4.0. Please use TaskInputs.file(Object).skipWhenEmpty() instead.
Download https://repo1.maven.org/maven2/com/facebook/android/facebook-android-sdk/4.14.1/facebook-android-sdk-4.14.1.pom
Download https://repo1.maven.org/maven2/com/parse/bolts/bolts-android/1.4.0/bolts-android-1.4.0.pom
Download https://repo1.maven.org/maven2/com/parse/bolts/bolts-tasks/1.4.0/bolts-tasks-1.4.0.pom
Download https://repo1.maven.org/maven2/com/parse/bolts/bolts-applinks/1.4.0/bolts-applinks-1.4.0.pom

FAILURE: Build failed with an exception.

  • What went wrong:
    A problem occurred configuring root project 'android'.

Could not resolve all dependencies for configuration ':_armv7DebugApkCopy'.
Could not find com.google.android.gms:play-services-ads:15.0.1.
Searched in the following locations:
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
Required by:
project :

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 2.849 secs
�[91m20181121T135351 [ERROR] AndroidBuilder -�[39m { Error: /workspace/platforms/android/gradlew: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

  • What went wrong:
    A problem occurred configuring root project 'android'.

Could not resolve all dependencies for configuration ':_armv7DebugApkCopy'.
Could not find com.google.android.gms:play-services-ads:15.0.1.
Searched in the following locations:
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom
file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar
Required by:
project :

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
    at ChildProcess.whenDone (/workspace/platforms/android/cordova/node_modules/cordova-common/src/superspawn.js:169:23)
    at ChildProcess.emit (events.js:182:13)
    at maybeClose (internal/child_process.js:961:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:248:5)
    stderr:
    '\nFAILURE: Build failed with an exception.\n\n* What went wrong:\nA problem occurred configuring root project 'android'.\n> Could not resolve all dependencies for configuration ':_armv7DebugApkCopy'.\n > Could not find com.google.android.gms:play-services-ads:15.0.1.\n Searched in the following locations:\n file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom\n file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/google/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar\n file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar\n file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.pom\n file:/opt/cocoon_compiler/workspace/production/data/sdks/android-sdks-linux/extras/android/m2repository/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar\n file:/workspace/platforms/android/sdk-manager/com/google/android/gms/play-services-ads/15.0.1/play-services-ads-15.0.1.jar\n Required by:\n project :\n\n* Try:\nRun with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.\n',
    stdout:
    'The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.\n\tat build_2r6c57ziz211y74otld4kkop.run(/workspace/platforms/android/build.gradle:139)\nThe JavaCompile.setDependencyCacheDir() method has been deprecated and is scheduled to be removed in Gradle 4.0.\nIncremental java compilation is an incubating feature.\nThe TaskInputs.source(Object) method has been deprecated and is scheduled to be removed in Gradle 4.0. Please use TaskInputs.file(Object).skipWhenEmpty() instead.\nDownload https://repo1.maven.org/maven2/com/facebook/android/facebook-android-sdk/4.14.1/facebook-android-sdk-4.14.1.pom\nDownload https://repo1.maven.org/maven2/com/parse/bolts/bolts-android/1.4.0/bolts-android-1.4.0.pom\nDownload https://repo1.maven.org/maven2/com/parse/bolts/bolts-tasks/1.4.0/bolts-tasks-1.4.0.pom\nDownload https://repo1.maven.org/maven2/com/parse/bolts/bolts-applinks/1.4.0/bolts-applinks-1.4.0.pom\n\nBUILD FAILED\n\nTotal time: 2.849 secs\n',
    code: 1 }

iOS 7.1 Issue - Interstitial crashes Phonegap Build

Hi

I've been spending the past day tinkering with this module. Overall looks good. However, I have been device testing and with my Interstitial which is as follows.

I have a feeling it has to do with this issue.

<a href="http://www.example.com/">Test link</a>

Causes PhoneGap to die when clicking the Hyperlink. To note this is on iOS 7.1 and Phonegap Build. Version details are cli-5.2.0 (iOS 3.9.1 / Android 4.1.1 ).

img_0250

Any help would be appreciated. Thanks!

Conflict of google services versions

I'm using PGB platform.

When I compile my App using cocoon-plugin-ads-android-admob and google-analytics-plugin the below error occurs.

  • What went wrong:
    Execution failed for task ':transformClassesWithDexForDebug'.

com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexException: Multiple dex files define Lcom/google/ads/AdRequest$ErrorCode;

Seems like the cocoon-plugin-ads-android-admob plugin.xml has use a old version of google services.

Do you can update the plugin to works with lastest version of google services?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.