As in this case you are exposing new endpoint/new API, you should secure it (especially in production scenario). Simplest way how to achieve it, is to use shared secret or API key.

please can you add some steps on how this can be achieved. Or atleast provide a reference to it. Thank you for this repo.

As with the botbuilder samples, it may be best to update the samples from camel casing to node casing (e.g. "advanced-sample")

The readme does a great job demonstrating how to build everything up, but it's difficult to understand what steps are needed to just run the sample, which ends up leading to a lot of guesswork.

Consider having a "Running this Sample" section at the top, with the fewest steps necessary, and then expanding on how it was built

Bot files are now deprecated:

Prior to the Bot Framework SDK 4.3 release, we offered the .bot file as a mechanism to manage resources. However, going forward we recommend that you use appsettings.json or .env file for managing these resources. Bots that use .bot file will continue to work for now even though the .bot file has been deprecated. If you've been using a .bot file to manage resources, follow the steps that apply to migrate the settings.

The bot file should be removed and replaced with instructions on running the bot with a .env file:

botFilePath="./basic.bot"
botFileSecret=""

Partially solves #16 .

Let's use this issue to track reviews of each sample in each language:

• Node Basic Sample
• Node Complex Sample
• C# Basic Sample
• C# Complex Sample

In the advanced sample I think that a minor refactor to pass the Cosmos client into the bot (from index.js) would clean up the code a bit. If developers use this sample as part of a larger bot that uses several services, it would be great to encourage this pattern.

I'm happy to take a stab at this!

The readme indicates that the reader should follow azure docs to create their cosmos instance, but its unclear what they should set their Partition Key to:

Readers need more specific guidance for configuring their services.

As of now, the readme in the advanced sample points devs at the Microsoft docs to get started with Cosmos. It may be a time-saver (and an interesting exercise) to consider including an ARM template to easily provision this (and maybe the bot?) for the end developer.

Please feel free to close this if you feel it's not the right approach! Just adding it as a matter of investigation.

As of now, it's not super clear that you're getting a proactive message. For the basic samples, let's increase the wait time to make it feel less like an echo.

What's happening

After the bot sends a proactive message and 2 minutes pass, there is a socket hang up.

Error after sending a single proactive message

Error after sending multiple proactive messages

Steps to reproduce

• Run the bot and send a proactive message.

• The bot will immediately and appropriately send back the proactive message.

• Wait 2 minutes and receive the following error in-console:

  [onTurnError]: FetchError: request to http://localhost:3978/api/proactive failed, reason: socket hang up

• The error will happen once for each proactive message that the bot sent, so long as the console and/or emulator are kept open for 2 minutes.

Solution

Nothing is done with res in the request, so send a status 200 OK.

Hi,

I'm trying to await dc.BeginDialogAsync in the Bot callback of your proactive endpoint. However there is no DialogContext to call the BeginDialogAsync method. Could you give an example of how i Could pass the DialogContext to the callback of the proactive endpoint so I can call a new dialog flow?

The azureFunction project has a package-lock.json, but no package.json, which is keeping me from being able to install necessary dependencies.

What's happening

Package-lock.json is not built correctly for the current state of the bot:

No matching version found for [email protected]. In most cases you or one of your dependencies are requesting a package version that doesn't exist.

Steps to reproduce

• Clone the repository
• Navigate to node\basic-sample\bot
• Run npm i

Solution

Delete package-lock.json, rebuild the solution, and then push up the new package-lock.json.

Before jumping into the how I think we'll want to address the why/what/when first. I'm happy to PR something in!