lucascheller / vfx-usdsurvivalguide Goto Github PK

Following the code given here
https://github.com/LucaScheller/VFX-UsdSurvivalGuide/blob/main/code/core/elements.py#L59

I faced the issue:
AttributeError: 'module' object has no attribute 'childDelimiter'

I think the correct code would be:
path = Sdf.Path(Sdf.Path.childDelimiter.join(["set", "bicycle"]))

Note: If you want I can too raise a PR.

On this website the links that link locally within the site don't work - unless you browse to the site using this url.

Fails: https://lucascheller.github.io/VFX-UsdSurvivalGuide/
Works: https://lucascheller.github.io/VFX-UsdSurvivalGuide/introduction/overview.html

They seem to to link to for example: ../introduction/motivation.md which takes the site from:
https://lucascheller.github.io/VFX-UsdSurvivalGuide/
to:
https://lucascheller.github.io/introduction/motivation.md

As such I assume the link has to be changed to introduction/motivation.md or alike. I wanted to create a PR for that. However, the current link does work in the previews on Github and will likely break the other URL that does work currently. As such I wasn't sure what the preferred way of fixing it was and instead opened this issue. :)

There is a issues in the Sdf.SpecifierOver: over code:

AttributeError: module 'pxr.Sdf' has no attribute 'SpecifierSdf'

My insights on this says this should be:
print(prim.GetSpecifier() == Sdf.SpecifierOver, prim.IsDefined())

Let me know what to change this to. I'll raise a PR afterwards.

Following the code given here
https://github.com/LucaScheller/VFX-UsdSurvivalGuide/blob/main/code/core/elements.py#L153

I faced the issue:
AttributeError: 'Path' object has no attribute 'GetAncestorRange'

I think the correct code would be:
for parent_path in variant_path.GetAncestorsRange():

Note: If you want I can too raise a PR.

Hi Luca,
Great book! Thank you for writing this. I just wanted to report a UI issue that's getting in the way of using the code examples.

When trying to copy the code examples manually by dragging the mouse over the code, the left navigation bar appears when moving to the beginning of the line, meaning that you can't start the drag operation to highlight the code.

When trying to press the "copy code" button instead in the top-right corner, the right navigation bar appears, preventing you from clicking it.

I don't know how much control you have over the theme to be able to tweak that, but maybe the code example boxes can have their outer margins brought in a bit to avoid the issue.

This is on Mac OS Ventura (13.0.1) with Chrome (116.0.5845.110)

Many thanks,
Andy

There is a issues in the High Level code:

NameError: name 'Kind' is not defined

The Kind module isn't imported, I'll be raising a PR fixing this.

There are few issues in the Properties code:

• https://github.com/LucaScheller/VFX-UsdSurvivalGuide/blob/main/code/core/elements.py#L108-L109

Issue:
AttributeError: 'str' object has no attribute 'name'
Possible Fixes:

path = Sdf.Path("/set/bicycle.tire:size")
property_name = path.name                 # Returns: 'tire:size'

• https://github.com/LucaScheller/VFX-UsdSurvivalGuide/blob/main/code/core/elements.py#L119

Issue:
AttributeError: 'module' object has no attribute 'path'
Possible Fixes:

last_element = Sdf.Path.StripNamespace("/set/bicycle.tire:size") # Returns: 'size'

• https://github.com/LucaScheller/VFX-UsdSurvivalGuide/blob/main/code/core/elements.py#L122

Issue:
ArgumentError: Python argument types in
Path.GetPrimPath(Path, Path)
did not match C++ signature:
GetPrimPath(pxrInternal_v0_21__pxrReserved__::SdfPath {lvalue})
Possible Fixes:

prim_path = path.GetPrimPath() # Returns: Sdf.Path('/set/bicycle')

or,

prim_path = Sdf.Path.GetPrimPath(path) # Returns: Sdf.Path('/set/bicycle')

Note: If you want I can too raise a PR.

There is a issues in the Prim Type Definition (High Level) code:

Boost.Python.ArgumentError: Python argument types in
PrimDefinition.FlattenTo(PrimDefinition, str)
did not match C++ signature:
FlattenTo(class pxrInternal_v0_22__pxrReserved__::UsdPrimDefinition {lvalue}, class pxrInternal_v0_22__pxrReserved__::TfWeakPtr<class pxrInternal_v0_22__pxrReserved__::SdfLayer> layer, class pxrInternal_v0_22__pxrReserved__::SdfPath path, enum pxrInternal_v0_22__pxrReserved__::SdfSpecifier newSpecSpecifier=Sdf.SpecifierOver)
FlattenTo(class pxrInternal_v0_22__pxrReserved__::UsdPrimDefinition {lvalue}, class pxrInternal_v0_22__pxrReserved__::UsdPrim parent, class pxrInternal_v0_22__pxrReserved__::TfToken name, enum pxrInternal_v0_22__pxrReserved__::SdfSpecifier newSpecSpecifier=Sdf.SpecifierOver)
FlattenTo(class pxrInternal_v0_22__pxrReserved__::UsdPrimDefinition {lvalue}, class pxrInternal_v0_22__pxrReserved__::UsdPrim prim, enum pxrInternal_v0_22__pxrReserved__::SdfSpecifier newSpecSpecifier=Sdf.SpecifierOver)

Following the code given here
https://github.com/LucaScheller/VFX-UsdSurvivalGuide/blob/main/docs/src/introduction/structure.md?plain=1#L77

I faced the issue:
AttributeError: type object 'Stage' has no attribute 'CreateAnonymous'

I think the correct code would be:
layer = Sdf.Layer.CreateAnonymous()