lucaperret / kap-now Goto Github PK

Do I somehow need to configure Kap to use my Now credentials, or does it just pull it from the now-cli config?

Kap seems to be stuck at "Creating Now Deployment" forever.

I have created a token, added it to the plugin, and double-checked the config file, it is also in there.

The "kapture" project is successfully created, but there doesn't seem to be any activity.

Is there any part of the setup I missed? Thank you!

With the new Kap 3.0 changes, we handle schema validation really well. So this should have an update schema 😄

When you create a deployment, the response body will have a missing: Array key, containing the files that you need to upload. That way, you'll only upload files we don't have yet.

Sure, it's virtually impossible that we already have a given Kapture, but it doesn't hurt to be a bit more correct 🙏

That said, thanks for implementing! I wrote a PoC a few months ago, but never published it 😅

▲ dev ls -lah kap-now
total 24
drwxr-xr-x  6 matheus  staff   204B Nov  6 05:04 .
drwxr-xr-x  8 matheus  staff   272B Nov 16 15:32 ..
-rw-r--r--  1 matheus  staff   2.4K Nov  6 05:04 index.js
drwxr-xr-x  8 matheus  staff   272B Nov  6 04:15 node_modules
-rw-r--r--  1 matheus  staff   323B Nov  5 14:52 package.json
-rw-r--r--  1 matheus  staff   963B Nov  5 13:39 yarn.lock
▲ dev 

Got this on my first try, on a very small gif. Tried to quit and re-opened kap after I added the Now plugin but didnt help:

Error: Response code 403 (Forbidden)
    at stream.catch.then.data (/Applications/Kap.app/Contents/Resources/app.asar/node_modules/got/index.js:341:13)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:135:7)

Getting this error after trying to upload a gif:

macOS version: Monterey (12)
Kap version: 3.4.1

RequestError

RequestError: certificate has expired
    at ClientRequest.<anonymous> (/Applications/Kap.app/Contents/Resources/app.asar/node_modules/got/source/request-as-event-emitter.js:178:14)
    at ClientRequest.origin.emit (/Applications/Kap.app/Contents/Resources/app.asar/node_modules/@szmarczak/http-timer/source/index.js:37:11)

Nice work on this plugin! Glad to see more Kap plugins in the ecosystem.

Some quick feedback:

• This can be removed:

  kap-now/index.js

  Line 11 in 94ced51

  context.setProgress('Read file…');

  Kap already sets progress for converting the file and reading it doesn't take long.
• This seems inefficient:

  kap-now/index.js

  Lines 13 to 17 in 94ced51

  	const data = await readFile(filePath);
  	const sha = createHash('sha1').update(data).digest('hex');
  	const stream = through2();
  	stream.write(data);
  	stream.end();

  Both crypto and the endpoint supports a stream, so you can just use a stream the whole way, using fs.createReadStream.

• kap-now/index.js

  Line 50 in 94ced51

  context.notify('URL to the video has been copied to the clipboard');

  It's not always a video. It can be a GIF or APNG too. You can use context.format for now and .toUpperCase() it. I'll add a new method later to get the pretty name: wulkano/Kap#389