lucalaringe / degiro_portfolio_analytics Goto Github PK

augment_product_details_csv function should allow no ETF related transactions

Thanks for sharing your work.
I got this error when I wanted to import my data:

Welcome!

Please type in your DeGiro Username and press enter:

Please type in your DeGiro Password and press enter:
Password:
Do you want to update your DeGiro transactions? (y/n)...y
Updating the transactions csv...

Done.

Type YES if you want the routine to move forward to the Historical data retrieval.

In case you wish to repeat the transactions csv update procedure for a different account, type NO. (y/n)... YES
Do you want to update your DeGiro Product Details? (y/n)...y
Updating the product details csv...

Traceback (most recent call last):
File "src/run_update.py", line 128, in
run_update()
File "src/run_update.py", line 98, in run_update
augment_product_details_csv(product_details_csv_path=product_details_csv_path)
File "/home/mohammad/workspace/web_dashboard/flaskdash/app/stock/thirdparty/tools/tmp/degiro_portfolio_analytics/src/just_etf_scraping.py", line 104, in augment_product_details_csv
just_etf_scraped_data = scrape_just_etf(isin_ls=etf_isin_ls)
File "/home/mohammad/workspace/web_dashboard/flaskdash/app/stock/thirdparty/tools/tmp/degiro_portfolio_analytics/src/just_etf_scraping.py", line 98, in scrape_just_etf
return pd.concat([scrape_just_etf([isin]) for isin in isin_ls], axis=0)
File "/home/mohammad/.local/lib/python3.8/site-packages/pandas/core/reshape/concat.py", line 274, in concat
op = _Concatenator(
File "/home/mohammad/.local/lib/python3.8/site-packages/pandas/core/reshape/concat.py", line 331, in init
raise ValueError("No objects to concatenate")
ValueError: No objects to concatenate

In my case:
PHI P17.00 21OKT22

I can get product_info:

{'id': '23214605', 'name': 'PHI P17.00 21OKT22', 'isin': 'NLEN07632792', 'symbol': 'PHI', 'contractSize': 100.0, 'productType': 'OPTION', 'productTypeId': 8, 'tradable': False, 'category': 'B', 'currency': 'EUR', 'active': False, 'expirationDate': '21-10-2022', 'strikePrice': 17.0, 'exchangeId': '1006', 'onlyEodPrices': False, 'orderTimeTypes': [], 'buyOrderTypes': [], 'sellOrderTypes': [], 'productBitTypes': [], 'closePrice': 3.73, 'closePriceDate': '2022-10-21', 'feedQuality': 'D15', 'orderBookDepth': 0, 'vwdIdentifierType': 'issueid', 'vwdId': '517965671', 'qualitySwitchable': True, 'qualitySwitchFree': False, 'vwdModuleId': 1}

But in
get real time price function it crashed because of degiroapi

In my case I had sold a put option of Grifols and there's no transactions type.

I'm inspecting the code here:

and I get this

Hi Luca!

Your work is awesome! I would like to share this with the biggest Degiro community in Telegram. But I'm afraid nobody will use it as people will not trust login with user and password in a third party tool for a financial app...

I have "audited" your code and I know what you do is secure and nice, but most people will not understand python or even if I understand Python I will not believe that in future degiroapi developers could change their 0.9.5 version with some bad thing to steal passwords or whatever....

The point is that all this could be solved if we allow uploading the data from CSV instead