losandes / gidget Goto Github PK

returns error Uncaught TypeError: Cannot read property 'data' of null

When clicking on a mailto link, the following error gets returned Uncaught TypeError: Cannot read property 'concat' of undefined

The error happens when clicking on empty space within the anchor but not when clicking on an element inside of the anchor.

<a data-bind="attr:{ href: emailMailtoLink }">
    <i class="icon icon_envelope envelope" title="Email User"/></i>
</a>

When calling router.redirect, the route that is redirecting should not be stored in history, as it breaks the back button. The easiest way to do this would be to:

1. update the history to make it where we are redirecting to
2. use router.get instead of router.navigate so we don't put an additional entry in the history

Currently, if a user uses an anchor instead of a button, and either omits the href or uses javascript:void(0), gidget throws an error. Omitting the href isn't valid HTML, so I'm not sure we should do anything about that, but void(0) is valid. Try to ignore the route action when it is empty, or when both javascript: and void( are present in the href.

I think it's a race condition when a route immediate navigates to another, the prior route may end up being the final state.

Right now we ignore any anchor that sets the target, but we should bind to it if the target is self.

So JSON data objects can be forwarded to appropriate endpoints.

It appears not to be working with the other pipeline features.

We either (a) shouldn't process these, or (b) should respect the target setting.

I saw this happen when an email address was passed in as a parameter (i.e. /users/:email).

This is breaking the route matching.