lootek / go-port-service Goto Github PK

The codebase contains tests for simple model-to-model transformations yet it lacks tests for core business logics.
Could you add tests that would verify correctness of the main functionality, please?

Please have a think should this be accomplished by extra unit tests, integration tests or perhaps both.

Usually in Golang applications context is propagated inside the app to allow for graceful shutdown. Could you review your implementation for context usage and make sure that context is properly propagated and used, please?

Port repository interface is defined as:

type Port interface {
	GetAll() []domain.Port
	Insert(port domain.Port) error
	Update(id string, port domain.Port) error
}

Could you review methods signatures and make sure they are future-proof and reusable, please?

Hints:

• if a method uses I/O operations, it's likely sometimes these operations may fail
• how do we retrieve a reference (id) to a newly inserted entity?