looksrare / contracts-libs Goto Github PK

Is your feature request related to a problem? Please describe.
It would be useful to add transfer helpers that can be building blocks for future smart contracts.

Describe the solution you'd like
It can include low-level calls (e.g., ETH, ERC20, ERC721, ERC1155) that can be re-used for many future contract iterations.

Is your feature request related to a problem? Please describe.
Unlike Ownable's library from OpenZeppelin, it is currently not possible to renounce the ownership of a contract. One of the reasons was that it is not possible to make it a 2-step process since the recipient shouldn't control the keys to "accept the transfer of ownership".

Describe the solution you'd like
A two-step process can be included to renounce ownership by adding a timelock: 1. renounce of ownership / 2. validate the ownership change to address(0)/burn address after timelock

Describe alternatives you've considered
Not adding this feature (as it is now)

Describe the bug
ERC20 tokens like USDT don't return true after a transfer. It can cause issues with the LowLevelERC20 contract.
https://etherscan.io/token/0xdac17f958d2ee523a2206206994597c13d831ec7#code

Expected behavior
It should allow the transfer of USDT and similar tokens.