Git Product home page Git Product logo

clippy-check's Introduction

clippy-check's People

Contributors

edfloreshz avatar loligothick avatar lucky3028 avatar renovate[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

clippy-check's Issues

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

github-actions
.github/workflows/ci.yml
  • actions/checkout v4
  • volta-cli/action v4
npm
package.json
  • @actions/core 1.10.1
  • @actions/exec 1.1.1
  • @actions/github 6.0.0
  • outdent 0.8.0
  • string-argv 0.3.2
  • @biomejs/biome 1.7.1
  • @types/core-js 2.5.8
  • @types/node 20.12.7
  • @vercel/ncc 0.38.1
  • typescript 5.4.5
  • node 20.12.2
  • yarn 1.22.22
  • yarn 1.22.22

  • Check this box to trigger a request for Renovate to run again on this repository

Bad argument formatting in dist/index.js

Run LoliGothick/clippy-check@master
  
Executing cargo fmt (JSON output)
  /home/runner/.cargo/bin/cargo clippy --message=format=json --all-features --
  error: Found argument '--message' which wasn't expected, or isn't valid in this context

    Did you mean '--message-format'?
  
  Usage: cargo check --message-format <FMT>

For more information try '--help'

After a search, it's formatted correctly in src/main.ts but in dist/index.js it has the extra = character.

Edit: This is probably because I used the reference in readme to us @master instead of specifying the tag, I see there was a fix for this but it is not reflected in the main repository.

Edit again: After looking further, seems the PR which fixes that and was released as v0.2.2 did not update dist/index.js only the file in src so the fix isn't affecting github actions

fails on non_std thumbv7em-none-eabihf target

  clippy_pybadge:
    runs-on: ubuntu-latest
    needs: [test_pc, check_pybadge]
    steps:
        - name: Install alsa, libudev
          run: sudo apt-get update && sudo apt-get install -y libasound2-dev libudev-dev
        - uses: actions/checkout@v2
        - uses: dtolnay/rust-toolchain@stable
          id: "rust-toolchain"
          with:
            components: clippy
            targets: thumbv7em-none-eabihf
        - uses: actions/cache@v3
          with:
            path: |
              ~/.cargo/git
              ~/.cargo/registry
              target
            key: "Clippy ${{runner.os}} Rust ${{steps.rust-toolchain.outputs.cachekey}} Lock ${{hashFiles('Cargo.lock')}}"
        - uses: LoliGothick/clippy-check@master
          with:
            token: ${{ secrets.GITHUB_TOKEN }}
            working-directory: pybadge

Looks like this action does still try to check for x86_64-unknown-linux-gnu even if thumbv7em-none-eabihf is the default toolchain and and thumbv7em-none-eabihf is set in the .cargo/config.toml.
https://github.com/LuckyTurtleDev/m3/actions/runs/5079399727/jobs/9125123200#step:6:229

  {"reason":"compiler-message","package_id":"m3-pybadge 0.1.0 (path+file:///home/runner/work/m3/m3/pybadge)","manifest_path":"/home/runner/work/m3/m3/pybadge/Cargo.toml","target":{"kind":["bin"],"crate_types":["bin"],"name":"m3-pybadge","src_path":"/home/runner/work/m3/m3/pybadge/src/main.rs","edition":"2021","doc":true,"doctest":false,"test":true},"message":{"rendered":"error: language item required, but not found: `eh_personality`\n  |\n  = note: this can occur when a binary crate with `#![no_std]` is compiled for a target where `eh_personality` is defined in the standard library\n  = help: you may be able to compile for a target that doesn't need `eh_personality`, specify a target with `--target` or in `.cargo/config`\n\n","children":[{"children":[],"code":null,"level":"note","message":"this can occur when a binary crate with `#![no_std]` is compiled for a target where `eh_personality` is defined in the standard library","rendered":null,"spans":[]},{"children":[],"code":null,"level":"help","message":"you may be able to compile for a target that doesn't need `eh_personality`, specify a target with `--target` or in `.cargo/config`","rendered":null,"spans":[]}],"code":null,"level":"error","message":"language item required, but not found: `eh_personality`","spans":[]}}

see: LuckyTurtleDev/mission2teegarden-b#34

Running cargo clippy in the pybadge directory manual does work fine.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.