loicfrering / backbone.datagrid Goto Github PK

Allow developper to pass its custom attributes during rows and cells building.

Hi,

Thanks for this component, it is very useful.

I have encountered a case that seems like a bug. In your documentation I read:
"cellClassName (string|callback)

The class name of the cell (td or th). It can be a string or a callback which will be passed the model related to the current row. "

Since there is no specific documentation for an actionClassName that is defined for a view of type ActionCell, I tried to follow the above and assign a function to it that is passed the row model. That did not work.

I have fixed it by editing the source code of Backbone.Datagrid, and replacing the lines
if (this.options.actionClassName) {
a.addClass(this.options.actionClassName);
}
with
if (this.options.actionClassName) {
var actionClassName = this.options.actionClassName;
if (_.isFunction(actionClassName)) {
actionClassName = actionClassName(this.model);
}
a.addClass(actionClassName);
}

It is working ok. I wonder if you think you can include it in a next release of Backbone.Datagrid?

when I run the github search example and click on next , then I get the following error, backbone.sync is called twice
http://localhost:8383/backbone/examples/function%20()%20%7B%20%20%20%20%20%20var%20base%20=%20_.result(this,%20'urlRoot')%20%7C%7C%20_.result(this.collection,%20'url')%20%7C%7C%20urlError();%20%20%20%20%20%20if%20(this.isNew())%20return%20base;%20%20%20%20%20%20return%20base%20+%20(base.charAt(base.length%20-%201)%20===%20'/'%20?%20''%20:%20'/')%20+%20encodeURIComponent(this.id);%20%20%20%20}&per_page=10&page=2

"this.options" is no more available in a view by default.

Please look at resthub/resthub-backbone-stack#124

Manage empty datagrid with a nice configurable message.

Hi,
how to personnalize header row icons without override the method ?
thanks

When there aren't any results, the datagrid's header is displayed with the emptyMessage. IMO, the header should not be displayed.

Hi,

I am using a remote API to fetch my collections from, and after upgrading Backbone to version 1.0, sorting did no longer work. This is because collection#fetch() does not trigger a 'reset' event by default any more.

I have fixed this locally by adding the reset:true property in the options object, in the _request funcion of Backbone.Datagrid, but I wonder if this is the best approach? If you think this is fine I would happily open a pull request.

Thanks,
Gerasimos

Hi,
On a Backbone view, when i init my DataGrid and set the view with a function using an underscore bind like this:

this.statsGrid = new DataGrid({
                          .....
            columns: [{
                title: PageLocalizing.grid.columnsLabels.skill,
                property: 'level, processingType',
                view: _.bind(function(model) {
                    return this.getProfile(model.level, model.processingType);
                }, this ),
                sortable: true
                }
                }
            ]
            });

this don't works but if i use Jquery proxy method :

this.statsGrid = new DataGrid({
                          .....
            columns: [{
                title: PageLocalizing.grid.columnsLabels.skill,
                property: 'level, processingType',
                view: $.proxy(function(model) {
                    return this.getProfile(model.level, model.processingType);
                }, this ),
                sortable: true
                }
                }
            ]
            });

It's works

Backbone version: 1.1.0
Underscore vs: 1.5.2
RequireJS version: 2.1.9
Google Chrome: 32.0.1700.76 m

I had to change a bunch of lines where the options are not passed as parameter to the initialize function to some views (almost all of them). Is this project still being supported?

Example:
From:

var Header = Datagrid.Header = Backbone.View.extend({
  tagName: 'thead',

  initialize: function() {
    this.columns = options.columns;
    this.sorter  = options.sorter;
  },

to:

    var Header = Datagrid.Header = Backbone.View.extend({
      tagName: 'thead',

  initialize: function(options) {
    this.columns = options.columns;
    this.sorter  = options.sorter;
  },

And this happens on every view definition.

The sorting is not working too.

I'm using it on a requirejs setup, included as a shim.

It could be interesting passing sort parameters at datagrid initialization. Actually, it works by rendering the datagrid, hence doing a server query, then activate a sort that does another query.
Passing a kind of sort parameters at initialization time would be nice to avoid this useless query

No sort is possible in this case

It would be nice if there was an option to change the order of the columns, by dragging the column and dropping it where you want like this : http://www.datatables.net/release-datatables/extras/ColReorder/index.html

Hi,

Although nowhere referenced in the readme, it seems to me that the generated html follows the bootstrap directives. I was using Bootstrap 2.3.2 in my project and it was working fine.

However, the html produced for the pagination controls in no longer works in Bootstrap 3. Specifically, the pagination classname should be assigned to the <ul> itself, not the surrounding div. To center the pagination controls you could simply add the text-center class in the surrounding div.

Is upgrading this part of Backbone Datagrid something you would consider?

In order to cleanup correctly event listeners when destroyed
Should specify that Backbone 0.9.10 or > is needed

Should be great to have this in 0.2.1 for Backbone RESThub stack 2.1 ;-)

Hi,

Is this possible that you compile and upload your new version of the code after you fixed the issue ?

Thanks you

in my web app, i create a new model and insert it to the colletion(use collection.push , collection.unshift or collection.add), but the grid seems dont get update.

i read the source code, found the grid only listening on 'reset' event.

When using a remote collection, when sorting data :

• the arguments are passed to the REST webservice
• the REST webservice returns the records sorted
• but the datagrid displays records in random order, not in the order the REST webservice returned them...

(Tested with datagrid v0.3.2)

Hi,
There is no indication about data loading.

The preventDefault method is not implemented in ie9. When you use the pagination buttons the browser will load # and erase your page.

The use of this.$("tbody") in Table.renderRow prevents nesting datagrids (they end up humerously out of shape). I changed to keep a private field this.$tbody in initialize to get round the problem.

When preparing the displayed model in callback-cell.js, it can be very handy to invoke the toJSON() method with a specific parameter.

This will allow developper to specifically format their model to fit the cell template: for example by getting embedded models attributes.

Hi,

I have really big data to be send to the datagrid and I display them per 50 in each page. My problem is that I have "<< 1 2 3 ... 40 >>" and this is taking more than a line and getting ugly on my page.

Do you already have a solution to have "<< ... 25 26 ... >>" instead for example or any idea about how doing it ?

Thank you