logchimp / theme Goto Github PK

Show a beautiful error message in the UI when SERVER_URL environment variable is missing.

Currently, we are passing multiple arguments to the API helper functions.

for example

export const getPublicBoards = async (page = 1, limit, sort = "desc") => {
	return await axios({
		method: "GET",
		url: "/api/v1/boards",
		params: {
			page,
			limit,
			created: sort
		}
	});
};

👆 source code

As getPublicBoards function accept multiple arguments, due to confusion in which order the arguments needs to be passed, can lead to unexpected results.

In resolution of that problem, we can change the arguments to a single object.

for example

export const getPublicBoards = async ({ 
  page = 1,
  limit,
  sort = "desc"
}) => {
  return await axios({
    method: "GET",
    url: "/api/v1/boards",
    params: {
      page,
      limit,
      created: sort
    }
  });
}

Running this test throws error TypeError: Cannot read property '0' of undefined.

      20 |
      21 | 		const value = wrapper.emitted("input");
    > 22 | 		expect(value[0]).toBe(true);
         | 		            ^
      23 | 	});
      24 | });
      25 |

Describe the bug
Unable to build non interactively with Docker

To Reproduce
Steps to reproduce the behaviour:

1. (using tiredofit/nginx:latest) apk add git nodejs yarn
2. yarn build --fix within Dockerfile
3. See error

Expected behaviour
Builds properly. It builds with the actual base Docker image in a bash shell, just not in Docker.

Examples of Errors

/app/theme/src/pages/Index.vue
  4:9  error  Replace `⏎↹↹↹↹v-for="post·in·posts"⏎↹↹↹↹:key="post.postId"⏎↹↹↹↹:post="post"⏎↹↹↹` with `·v-for="post·in·posts"·:key="post.postId"·:post="post"·`  prettier/prettier

/app/theme/src/pages/Join.vue
   9:5   error  Insert `/`                                                                                                                                          prettier/prettier
  41:12  error  Replace `⏎↹↹↹↹↹type="primary"⏎↹↹↹↹↹:loading="buttonLoading"⏎↹↹↹↹↹@click="join"⏎↹↹↹↹` with `·type="primary"·:loading="buttonLoading"·@click="join"`  prettier/prettier

and more..

Additional thoughts
Looks to be problems with tabs. Standardize to spacing instead of tabs to avoid this issue. The --fix argument shouldn't need to be used regardless.

Add colour picker for changing colour.

UPDATE: ColorInput component has been created (Jan 08, 2021)

This issue will stretch across multiple milestones.

• /
• /boards - logchimp/logchimp#98

@everyone is a default role created when setting up LogChimp and should not be renamed from the theme.

Describe the bug

(Before splitting the codebase, there was no such error)

Getting regeneratorRuntime is not defined error in client app, but the tests are passing.

But after removing babel.config.js file, the client app issue gets resolved, but tests start failing.

module.exports = {
	presets: ["@babel/preset-env"],
	plugins: ["transform-require-context"]
};

Screenshots

Resources

• https://freecodecamp.org/news/how-to-use-lighthouse-in-github-actions/
• https://github.com/GoogleChrome/lighthouse-ci

Add direction props dropdown component and based on that show the dropdown.

• top
• bottom
• left
• right

Don't store site settings in localStorage get data via API on every page.