loebl / carve Goto Github PK

There are two Face classes, with probably overlapping functionality. Can the be merged?

Function polyhedronFromMesh (mesh.cpp:942):

If the else branch is taken, poly->manifold_is_closed will be resized to one, then element manifold_id will be accessed, resulting in an out of bounds access for everything other than manifold_id = 0.

Will come up during mesh_unittest.

Apparently CSG::compute once operated on the Polyhedron class. Now it uses a MeshSet. I currently don't have an overview over shared/exclusive functionality for each class, but it might be reasonable that there is some code duplication/function overlap.

Check if one class can be eliminated in favor of the other.