This PR currently shows a "Running CI build with LocalStack" even though the preview deployment is already in place, i.e the preview action has finished.
Checking out the action execution (attached screenshot) shows that the number argument to the maintain-one-comment is 16, which is not the correct number. It should be 17, as that's the number of the PR.

Checking out the previous PR (#16), shows that the comment has been added there instead.

Issue Description

The main action accepts preview-url as an option, however it doesn't forward it to the finish action.

Proposed Solution

Add it as an option to the call.

Using the windows-2019 runner, this action produces this error:

Error: 'charmap' codec can't encode character '\U0001f4bb' in position 1: character maps to <undefined>

It appears that this is a manifestation of https://docs.localstack.cloud/getting-started/faq/#how-to-fix-localstack-cli-python-utf-8-encoding-issue-under-windows, but I would expect that the action would handle this for me.

This relates to localstack/localstack#6051

I'm using pretty much the example integration in my workflow:

      - name: Start LocalStack
        uses: LocalStack/[email protected]
        with:
          image-tag: latest
          install-awslocal: true
          use-pro: false

But no matter what I put as the image-tag, I'd always get v3.2.0, which doesn't work for us due to localstack/localstack#10621. So I must use v3.4.0 (or 2.2.0 - which we've used before).

FWIW: I'm seeing similar odd behaviour installing a specific version using pip3 install localstack==2.2.0. It would seemingly install that version, but I'd still get the above issue.

Error description

setup-localstack run fails at the sub-module lookup if the name set in a lower-case manner.

How to reproduce

uses: localstack/[email protected]
...

Error output

Proposed solution

Make setup-localstack case insensitive by using grep -i in the local cache hack.

Issue Description

The parsed JSONs the action creates for the sub-modules are not substituted/parsed properly and dropping new line characters. Hence runs are failing with such input especially if the new lines are not just for cosmetics ie in the case of preview-cmd.
Additionally " characters are causing issues.

How to reproduce

- name: Deploy Preview
        uses: LocalStack/[email protected]
        env:
          LOCALSTACK_API_KEY: ${{ secrets.LOCALSTACK_API_KEY }}
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          state-backend: ephemeral
          state-action: start
          include-preview: 'true'
          install-awslocal: 'true'
          # Multi line commands are folding for some reason, so we enforce new lines
          # For more predictable usage, use script files
          preview-cmd: |
            npm install -g aws-cdk-local aws-cdk
            echo "HelloWorld"

Output

Proposed Solution

Use toJSON with every parameter in the JSON inputs.