lobodol / 2minutesdupeuple Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 2.16 MB

Reponsive web player

Home Page: http://www.les2minutesdupeuple.ml

JavaScript 33.23% PHP 27.58% SCSS 35.05% Shell 0.18% Makefile 1.85% Dockerfile 2.11%

css php scss webpack-encore

2minutesdupeuple's Introduction

Hi there 👋

2minutesdupeuple's People

Contributors

Watchers

2minutesdupeuple's Issues

Stop using jQuery

'[email protected]' has 4 known vulnerabilities (4 medium).

Moreover, there is no reason to keep using it as modern JS is aweseome.

Add robots.txt

This file is missing

Use dotenv for app configuration

Currently, app config (such as database credentials) is defined in config/database.ini which is not a standard way of doing this.

Symfony dotenv component would be a good choice.

OpenGraph, Schema.org, Twitter cards

These are missing. Let's see if needed then, add them.

Use Webpack to manage assets

Currently, asset building is done with a custom Gulp config.

That was fine at the beginning but now has a lack of many things:

source maps
versioning
integrity hashes
...

Using Webpack Encore will allow to do such things, and way more.

External link disopener

Add attributes rel="noopener" & rel="noreferrer" to Facebook and Twitter share links.

Missing sitemap.xml

This file is missing

Branded 404 page

Use a custom 404 page instead of Apache's default.

Minify SVG

Some SVGs can be minified.

MediaSession seekto

Implement handler for MediaSession seekto allowing Android users to move the playback position to the specified time within the media.

Use Docker

Configure a Docker environment for this project.

Use a public directory

Currently, index.php is in the project root. As a result, the server has to serve the root directory which can lead to sensitive data exposure.

With a /public directory served, the problem no longer arises.

Customize Media Notifications

https://developers.google.com/web/updates/2017/02/media-session

Fix Twitter share link

The Twitter share link does nothing

Missing h1 tag

There is no <h1> tag which can lead in SEO issue.

Security.txt

Add a file under /.well-known/security.txt to tell what to do if a security issue is found.

https://securitytxt.org/

Use SVG instead of spritesheet

Pictures are pixelated, specially when using a mobile which is ugly.

Using SVG would be better. Moreover, generating a sprite sheet will be no longer needed.

Empty link in search pannel

<div id="recherche">
            <a href="#"></a>
...

What is the purpose of this empty link?

Add link to share a track

Add a link to share a track including stating time (like YouYube)

Minify images with Webpack

Instead of doing this manually, it could be nice to automate it.

https://webpack.js.org/plugins/image-minimizer-webpack-plugin/

Upgrade jQuery

As an intermediate state of #6, upgrade jQuery to the latest release would handle security issues.